Page MenuHomePhabricator

Large differential fails to load
Closed, ResolvedPublic

Description

I made a very large change to one of our repositories, essentially running git mv some/subdir/* ./. Locally, I had two commits: one which did the git mv and a subsequent commit which fixed up any path references. I wanted to get this change code reviewed to some extent, so I did arc diff HEAD~ to submit a revision for review. Upon landing this change, I am now no longer able to view the revision in the web UI. Specifically, I get a "maximum execution time" error. Setting debug.time-limit to 20 seconds, I get the following trace:

Request aborted by debug time limit after 20 seconds.

STACK TRACE
LiskDAO.php:609 PhabricatorStartup->onDebugTick()
LiskDAO.php:655 LiskDAO->loadFromArray()
DifferentialChangesetQuery.php:56 LiskDAO->loadAllFromArray()
PhabricatorPolicyAwareQuery.php:227 DifferentialChangesetQuery->loadPage()
DifferentialRevisionViewController.php:699 PhabricatorPolicyAwareQuery->execute()
DifferentialRevisionViewController.php:81 DifferentialRevisionViewController->loadChangesetsAndVsMap()
AphrontController.php:33 DifferentialRevisionViewController->processRequest()
AphrontApplicationConfiguration.php:226 AphrontController->handleRequest()
AphrontApplicationConfiguration.php:140 AphrontApplicationConfiguration->processRequest()
index.php:21 AphrontApplicationConfiguration->runHTTPRequest()

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Differential.
joshuaspence added a subscriber: joshuaspence.
epriestley claimed this task.
epriestley added a subscriber: epriestley.

I think this is covered by T8612, unless you can produce a small change which requires a disproportionately large amount of time to render. It is expected that large changes will take a proportionately large amount of time to render.