Page MenuHomePhabricator
Differential D12506

Don't escape quotation marks when printing the monospaced CSS rule
ClosedPublic
Actions

Authored by epriestley on Apr 22 2015, 4:26 PM.
Tags
None
Referenced Files
F15432208: D12506.diff
Mon, Mar 24, 4:46 PM
F15423215: D12506.id.diff
Sat, Mar 22, 2:01 PM
F15419913: D12506.id30026.diff
Fri, Mar 21, 9:53 AM
F15416550: D12506.diff
Thu, Mar 20, 11:58 AM
F15401159: D12506.id.diff
Mon, Mar 17, 4:03 PM
F15396911: D12506.id30027.diff
Sun, Mar 16, 4:55 PM
F15382096: D12506.diff
Fri, Mar 14, 10:39 AM
F15360398: D12506.diff
Tue, Mar 11, 8:27 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T7888: Document that "Monospaced Font Preference" must be a valid CSS "Font" rule
Commits
Restricted Diffusion Commit
rPe7702acdc659: Don't escape quotation marks when printing the monospaced CSS rule
Summary

Fixes T7888. This is currently safe, but double quotes are incorrectly escaped.

To keep them unescaped, we have to punch through PhutilSafeHTML a bit. Since the allowable characters are strictly filtered this is still safe in practice, just not as theoretically-safe.

Test Plan

Set font to 32px "impact" (with quotes), saw impact font.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30026.Apr 22 2015, 4:26 PM
epriestley retitled this revision from to Don't escape quotation marks when printing the monospaced CSS rule.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7888: Document that "Monospaced Font Preference" must be a valid CSS "Font" rule.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 22 2015, 4:26 PM
chad accepted this revision.Apr 22 2015, 4:28 PM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Apr 22 2015, 4:28 PM
Closed by commit rPe7702acdc659: Don't escape quotation marks when printing the monospaced CSS rule (authored by epriestley, committed by epriestley). · Explain WhyApr 22 2015, 4:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
settings/
panel/
5 lines
storage/
5 lines
view/
page/
11 lines

Diff 30027

View Options

src/applications/settings/panel/PhabricatorDisplayPreferencesSettingsPanel.php

Loading...
View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
Phabricator · Built by Phacility