Page MenuHomePhabricator

Align the navigation buttons for inline comment toolbar
Closed, DuplicatePublic

Description

I've found myself navigating through the comments of revisions using the provided arrow buttons using a mouse. The buttons currently don't align, so if I'm cycling through comments and get navigated to one of mine which still in draft, the draft tools appear. The draft tools show up where the arrow keys are located on submitted comments, and I find myself either going into edit mode or trashing my draft instead of skipping. It would be convenient if the arrow buttons always aligned in this case.

Screen_Shot_2015-04-17_at_2.22.40_PM.png (383×565 px, 30 KB)

Event Timeline

cspeckmim raised the priority of this task from to Needs Triage.
cspeckmim updated the task description. (Show Details)
cspeckmim added a subscriber: cspeckmim.

My concern here is we're lending preference to one developers workflow over another. I'm generally of the opinion we should be as agnostic as possible in the UI around these things. The UI is designed around the notion that the Done state is the most important to anchor the header. Keyboard shortcuts are already provided for navigating more easily between next and previous comments.

My concern here is we're lending preference to one developers workflow over another.

I understand, just thought I would provide a data point for this in that cycling through the comments could be repetitive action for users.

Playing with the interaction, it's not doing what I'd prefer anyways, which is anchor you to the first line of highlighted code. That feature would make pursuing this moot since the box would jump around regardless, or at least in a handful of cases where multiple lines were selected.

Closing into T5030, if we can figure something out, we will, but with variable line selections, seems not probable.