Page MenuHomePhabricator

1-up Renderer should probably render comments full-width
Closed, WontfixPublic

Description

On mobile displays, comments are very compact, and the th next to them provide no value, maybe we should collapse here so the comment can be full width.

pasted_file (362×313 px, 50 KB)

Event Timeline

chad raised the priority of this task from to Needs Triage.
chad updated the task description. (Show Details)
chad added a project: Differential.
chad updated the task description. (Show Details)
chad added subscribers: chad, epriestley.
eadler added a project: Restricted Project.Aug 5 2016, 5:23 PM
epriestley claimed this task.

I think the complexity of changing this probably isn't worth the benefit. The complexity is high because of how much client-side interaction there is around inlines, and even with more space for the inline, the example screenshot doesn't seem great for code review anyway since none of the code fits.

Other thoughts:

  • It has also been a few years and devices generally have larger screens and higher resolution, and this problem will likely continue to solve itself over time.
  • This might negatively impact screen readers? At least some screenreader users are using 1-up for normal review.

This might come up again in the future, but seems like it's probably more trouble than it's worth for now.