Page MenuHomePhabricator
Create Task
Maniphest T7344

Prompt when creating a new commit from working copy changes in immutable history repositories should used $EDITOR
Closed, ResolvedPublic
Actions

Description

When prompted during an arc diff for commit message, arrow keys are not usable. Instead of moving the cursor, the control characters are entered on the console instead of navigating through the message in order to make corrections or insert. The delete key can be used to move backwards to make corrections.

System: OS X 10.9

Revisions and Commits

rARC Arcanist
D11843rARCdd59423d56ad Use $EDITOR to prompt users when creating a new commit out of dirty working…

Related Objects

Event Timeline

cspeckmim created this task.Feb 20 2015, 11:21 PM
cspeckmim raised the priority of this task from to Needs Triage.
cspeckmim updated the task description. (Show Details)
cspeckmim added a subscriber: cspeckmim.
chad added a subscriber: chad.Feb 20 2015, 11:22 PM

Ummmm, isn't that whatever editor you use? We don't have a console.

epriestley added a subscriber: epriestley.Feb 20 2015, 11:28 PM

Yeah, I think this is either a terminal configuration issue or an $EDITOR problem.

What does this show?

echo $EDITOR

...and does this "fix" it?

arc set-config editor nano
cspeckmim added a comment.Feb 20 2015, 11:28 PM

I have nano configured as my editor, and it does load when writing out the full commit message. But when I use arc diff this is what happens:

  1. From console, uncommitted files are listed and I am prompted whether to add to diff or not.
  2. I select yes to add them to diff.
  3. From console I am prompted to enter a commit message for these files.
  4. I enter a commit message and hit enter.
  5. My editor (nano) is opened for me to enter a commit message which includes summary, test plan, reviewers, subscribers.

The problem I'm seeing is in step 3. I have attached a screenshot

console.png (262×758 px, 52 KB)

chad added a comment.Feb 20 2015, 11:29 PM
                              .__           __  .__             ___.                    __   
  ____ _____    ____   ____   |__| ______ _/  |_|  |__   ____   \_ |__   ____   _______/  |_ 
 /    \\__  \  /    \ /  _ \  |  |/  ___/ \   __\  |  \_/ __ \   | __ \_/ __ \ /  ___/\   __\
|   |  \/ __ \|   |  (  <_> ) |  |\___ \   |  | |   Y  \  ___/   | \_\ \  ___/ \___ \  |  |  
|___|  (____  /___|  /\____/  |__/____  >  |__| |___|  /\___  >  |___  /\___  >____  > |__|  
     \/     \/     \/                 \/             \/     \/       \/     \/     \/
epriestley added a comment.Feb 20 2015, 11:29 PM

Aaah, okay. We should pop $EDITOR for that, I think it's just hg + immutable history specific.

epriestley renamed this task from Arcanist console user input has some limitations to Prompt when creating a new commit from working copy changes in immutable history repositories should used $EDITOR.Feb 20 2015, 11:30 PM
epriestley triaged this task as Normal priority.
epriestley added a project: Arcanist.
cspeckmim added a comment.Feb 20 2015, 11:32 PM

I tried arc set-config editor nano and it didn't change the process.
I am using mercurial and in .arcconfig:

"history.immutable": false
epriestley mentioned this in D11667: Arcanist / Conduit - stop using deprecated diffusion.getcommits.Feb 21 2015, 12:37 AM
epriestley added a revision: D11843: Use $EDITOR to prompt users when creating a new commit out of dirty working copy changes.Feb 21 2015, 12:38 AM
epriestley closed this task as Resolved by committing rARCdd59423d56ad: Use $EDITOR to prompt users when creating a new commit out of dirty working….Feb 21 2015, 10:38 AM
epriestley added a commit: rARCdd59423d56ad: Use $EDITOR to prompt users when creating a new commit out of dirty working….
Phabricator · Built by Phacility