Select a similar or better FontAwesome icon to represent each application
Details
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
Restricted Diffusion Commit
rP0ab065a14b4e: derp
rP5d8bb61dde25: Add FontIcon bridge to AppIcons
Visual inspection
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I was worried that we're going to end up with icons not being distinctive enough, but these actually look pretty good after reading through them (recognizable, relevant, not heavily overloaded in the UI).
| src/applications/celerity/application/PhabricatorCelerityApplication.php | ||
|---|---|---|
| 17–19 ↗ | (On Diff #27638) | This isn't actually ever used so we could use it elsewhere. |
| src/applications/config/application/PhabricatorConfigApplication.php | ||
| 14 ↗ | (On Diff #27638) | Same as settings, maybe cogs? Or paint-brush? Or fa-sliders? |
| src/applications/countdown/application/PhabricatorCountdownApplication.php | ||
| 14 ↗ | (On Diff #27638) | Maybe fa-rocket? But it feels wasteful to use the best icon on this. |
| src/applications/daemon/application/PhabricatorDaemonsApplication.php | ||
| 26 ↗ | (On Diff #27638) | Haha, I like this. Next best thing I could come up with was fa-plug, maybe. |
| src/applications/diffusion/application/PhabricatorDiffusionApplication.php | ||
| 22 ↗ | (On Diff #27638) | Maybe swap this with Repositories. In the long run I want to remove Repositories, and I think the disk is a better icon for this role. |
| src/applications/diviner/application/PhabricatorDivinerApplication.php | ||
| 14 ↗ | (On Diff #27638) | Maybe just fa-dot-circle-o since we use the similar-looking fisheye glyph internally and this is fairly abstract anyway? Or fa-life-ring for "help"? |
| src/applications/doorkeeper/application/PhabricatorDoorkeeperApplication.php | ||
| 18 ↗ | (On Diff #27638) | Ehh, but I don't have a better one. |
| src/applications/fact/application/PhabricatorFactApplication.php | ||
| 22 ↗ | (On Diff #27638) | Maybe fa-line-chart? That one is a little more recognizable to me. |
| src/applications/herald/application/PhabricatorHeraldApplication.php | ||
| 14 ↗ | (On Diff #27638) | Same as notifications -- maybe make one (notifications?) fa-bullhorn? |
Comment Actions
Made all other changes. Diffusion still up in the air. For now I'm just going to replace the feed 1x icons and remote that sprite as a trial.
| src/applications/diffusion/application/PhabricatorDiffusionApplication.php | ||
|---|---|---|
| 22 ↗ | (On Diff #27638) | I think most people use Diffusion to 'browse code', not as many people 'configure repository' ? |
Comment Actions
Yeah, it could go either way -- personally, I just think the code icon is pretty ambiguous and doesn't say "code" to me very strongly (looks like "HTML WSYWIG Editor" to me), while the storage icon feels more like "go look at your data (which happens to be code)", and I do think of Diffusion like that.
Comment Actions
Some competitors also use the code icon, from poking around. Main thing to think about is if it was just the icon, would you still know what app it was. Visual reference:
Diffusion
Diffusion
Diffusion
Comment Actions
Oh, I do like file-code-o a little better than just code if that seems like a reasonable approach (but I don't really feel too strongly, and you're obviously right that "storage" has no real association with "code").