Page MenuHomePhabricator
Create Task
Maniphest T6927

Would be nice if .arcconfig supported prepopulation of the reviewers and ccs fields
Closed, WontfixPublic
Actions

Description

Arc is great in that it lets you specify the list of reviewers and ccs in the diff submittal process. But if a team has a consistent set of developers, typical of a company setting, it is a burden to retype each developer ID in for each review. Requested change is for arc to support setting a default list of reviewers and ccs in the .arcconfig file.

Event Timeline

ScopiCisco created this task.Jan 10 2015, 7:05 PM
ScopiCisco raised the priority of this task from to Normal.
ScopiCisco updated the task description. (Show Details)
ScopiCisco added a project: Arcanist.
ScopiCisco added a subscriber: ScopiCisco.

Proposed changes would be to the files

src/configuration/ArcanistSettings.php
src/workflow/ArcanistDiffWorkflow.php
src/workingcopyidentity/ArcanistWorkingCopyIdentity.php

chad added a subscriber: chad.Jan 10 2015, 7:17 PM

reviewers are passable via the command line, make an alias?

ScopiCisco added a comment.Jan 10 2015, 7:30 PM

Can you provide a demonstration of the proper syntax? I did try several forms of passing in reviewers on the command line and "arc" didn't like the format.

Otherwise, yes I was going to have our team create an alias for diff.

chad added a comment.Jan 10 2015, 7:41 PM

I am not a command-line master, but I did get this to trigger:

arc diff --reviewers 'epriestley, btrahan'

chad raised the priority of this task from Normal to Needs Triage.Jan 10 2015, 11:15 PM
joshuaspence added a subscriber: joshuaspence.Jan 11 2015, 8:32 PM

You could also create a Herald rule to add reviewers to a diff.

epriestley closed this task as Wontfix.Jan 12 2015, 8:47 PM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

We don't plan to support this. Herald or the CLI flags might be good alternatives.

Phabricator · Built by Phacility