Page MenuHomePhabricator
Create Task
Maniphest T6917

PhabricatorApplicationTransactionNoEffectException when saving Blocked tasks without changing them
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Click Edit Blocking Tasks
  2. Click Save Blocking Tasks

Result:

Unhandled Exception ("PhabricatorApplicationTransactionNoEffectException")
Transactions have no effect:

  • Edges already exist; transaction has no effect.

Expected result:
None.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

valhallasw created this task.Jan 9 2015, 2:46 PM
valhallasw raised the priority of this task from to Needs Triage.
valhallasw updated the task description. (Show Details)
valhallasw added a project: Maniphest.
valhallasw added a subscriber: valhallasw.
epriestley assigned this task to lpriestley.EditedJan 9 2015, 3:00 PM
epriestley added a subscriber: epriestley.

The fix for this is probably to add ->setContinueOnNoEffect(true) to the $txn_editor in PhabricatorSearchAttachController:

        $txn_editor = $object->getApplicationTransactionEditor()
          ->setActor($user)
          ->setContentSourceFromRequest($request)
+         ->setContinueOnNoEffect(true)
          ->setContinueOnMissingFields(true);

If that doesn't work, this might be messy.

qgil added a subscriber: qgil.Jan 9 2015, 3:01 PM
lpriestley added a revision: Restricted Differential Revision.Jan 12 2015, 9:46 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jan 12 2015, 9:47 PM
epriestley added a commit: Restricted Diffusion Commit.
Phabricator · Built by Phacility