Page MenuHomePhabricator
Differential D11353

T6917, PhabricatorApplicationTransactionNoEffectException when saving "blocking tasks" without changing them
ClosedPublic
Actions

Authored by lpriestley on Jan 12 2015, 9:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 12:56 PM
Unknown Object (File)
Sat, Dec 7, 1:37 AM
Unknown Object (File)
Thu, Dec 5, 9:58 PM
Unknown Object (File)
Sat, Nov 30, 3:50 PM
Unknown Object (File)
Mon, Nov 25, 5:51 AM
Unknown Object (File)
Nov 18 2024, 5:46 PM
Unknown Object (File)
Nov 1 2024, 2:22 PM
Unknown Object (File)
Oct 30 2024, 11:50 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6917: PhabricatorApplicationTransactionNoEffectException when saving Blocked tasks without changing them
Commits
Restricted Diffusion Commit
rPfa47c2690720: T6917, PhabricatorApplicationTransactionNoEffectException when saving…
Summary

Fixes T6917, swallow exception when saving blocking tasks with no changes

Test Plan

Open task, "Edit Blocking Tasks", save without changing, dialog should close with no exception

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 27278.Jan 12 2015, 9:46 PM
lpriestley retitled this revision from to T6917, PhabricatorApplicationTransactionNoEffectException when saving "blocking tasks" without changing them.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T6917: PhabricatorApplicationTransactionNoEffectException when saving Blocked tasks without changing them.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 12 2015, 9:46 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 12 2015, 9:46 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2015, 9:46 PM
Closed by commit rPfa47c2690720: T6917, PhabricatorApplicationTransactionNoEffectException when saving… (authored by lpriestley, committed by epriestley). · Explain WhyJan 12 2015, 9:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
controller/
3 lines

Diff 27279

View Options

src/applications/search/controller/PhabricatorSearchAttachController.php

Loading...
Phabricator · Built by Phacility