Page MenuHomePhabricator
Create Task
Maniphest T6874

Inline comments should be threaded in the Diffusion top level view.
Closed, WontfixPublic
Actions

Description

When there is a discussion happening in the code review about a specific section of the code, all inline comments that apply to the same lines should be grouped together so that it is possible to see the conversation as it develops.
Currently you can only see this by navigating to the actual lines in the review, but the comments are no longer visible after the code is updated. It seems like it would be easier to follow the flow of the review if all comments that were related were grouped together rather than being in strict chronological order.

Related Objects

Event Timeline

anton.vladimirov created this task.Jan 6 2015, 1:10 AM
anton.vladimirov raised the priority of this task from to Needs Triage.
anton.vladimirov updated the task description. (Show Details)
anton.vladimirov mentioned this in T6873: Differential could provide actual content of context lines of code for inline comments.
anton.vladimirov added a subscriber: anton.vladimirov.
epriestley closed this task as Wontfix.Jan 6 2015, 1:13 AM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

Some discussion in T1460, but we don't plan to pursue this, at least as the primary view.

Notably, threading comments makes it very difficult to identify which comments are new.

anton.vladimirov added a comment.Jan 6 2015, 1:15 AM

I agree about that "new" thing.
Do you guys have plans to persist threaded view in code itself through rev updates?

anton.vladimirov mentioned this in T6876: Differential should preserve inline comments in code through revision updates.Jan 6 2015, 8:36 PM
chad mentioned this in T11235: Threaded comments.Jun 30 2016, 1:16 AM
Phabricator · Built by Phacility