Page MenuHomePhabricator
Create Task
Maniphest T6608

Some use of PhutilUTF8StringTruncator are not aggressive enough
Closed, ResolvedPublic
Actions

Description

Our phabricator daemons continue to emit this error into the daemon long.

[20-Nov-2014 23:57:25] [2014-11-20 23:57:25] EXCEPTION: (PhutilProxyException) Error while executing task ID 11143 from queue. {>} (AphrontQueryException) #1406: Data too long for column 'summary' at row 1 at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:308]
[20-Nov-2014 23:57:25]   #0 AphrontBaseMySQLDatabaseConnection::throwQueryCodeException(integer, string) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:275]
[20-Nov-2014 23:57:25]   #1 AphrontBaseMySQLDatabaseConnection::throwQueryException(mysqli) called at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:181]
[20-Nov-2014 23:57:25]   #2 AphrontBaseMySQLDatabaseConnection::executeRawQuery(string) called at [<phutil>/src/xsprintf/queryfx.php:6]
[20-Nov-2014 23:57:25]   #3 queryfx(AphrontMySQLiDatabaseConnection, string, string, string, string, string)
[20-Nov-2014 23:57:25]   #4 call_user_func_array(string, array) called at [<phutil>/src/aphront/storage/connection/AphrontDatabaseConnection.php:26]
[20-Nov-2014 23:57:25]   #5 AphrontDatabaseConnection::query(string, string, string, string, string) called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1112]
[20-Nov-2014 23:57:25]   #6 LiskDAO::update() called at [<phabricator>/src/infrastructure/storage/lisk/LiskDAO.php:1041]
[20-Nov-2014 23:57:25]   #7 LiskDAO::save() called at [<phabricator>/src/applications/repository/storage/PhabricatorRepositoryCommit.php:169]
[20-Nov-2014 23:57:25]   #8 PhabricatorRepositoryCommit::save() called at [<phabricator>/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php:80]
[20-Nov-2014 23:57:25]   #9 PhabricatorRepositoryCommitMessageParserWorker::updateCommitData(DiffusionCommitRef) called at [<phabricator>/src/applications/repository/worker/commitmessageparser/PhabricatorRepositorySvnCommitMessageParserWorker.php:15]
[20-Nov-2014 23:57:25]   #10 PhabricatorRepositorySvnCommitMessageParserWorker::parseCommit(PhabricatorRepository, PhabricatorRepositoryCommit) called at [<phabricator>/src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php:44]
[20-Nov-2014 23:57:25]   #11 PhabricatorRepositoryCommitParserWorker::doWork() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorWorker.php:87]
[20-Nov-2014 23:57:25]   #12 PhabricatorWorker::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php:156]
[20-Nov-2014 23:57:25]   #13 PhabricatorWorkerActiveTask::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php:19]
[20-Nov-2014 23:57:25]   #14 PhabricatorTaskmasterDaemon::run() called at [<phutil>/src/daemon/PhutilDaemon.php:91]
[20-Nov-2014 23:57:25]   #15 PhutilDaemon::execute() called at [<phutil>/scripts/daemon/exec/exec_daemon.php:111]

Any idea why this is? Is it as simple as a summary in commit message being too long? Or is it something more?

Revisions and Commits

rPHU libphutil
D11220rPHUb19a507367b5 Remove "like MySQL" doc block hint
rP Phabricator
D11219rP384b670709aa Fix string truncation calls all over the codebase.

Related Objects

Event Timeline

pmepablo created this task.Nov 21 2014, 5:19 AM
pmepablo assigned this task to chad.
pmepablo raised the priority of this task from to High.
pmepablo updated the task description. (Show Details)
pmepablo added a subscriber: pmepablo.
chad removed chad as the assignee of this task.Nov 21 2014, 5:26 AM
chad raised the priority of this task from High to Needs Triage.
chad added a subscriber: chad.Nov 21 2014, 5:29 AM

Some discussion in T5968

pmepablo updated the task description. (Show Details)Nov 21 2014, 5:58 AM
pmepablo added a comment.Nov 21 2014, 6:01 AM

I was able to get the daemons in configuration. Needed to restart the httpd service (I'd restarted everything else but may not have done that one). Now it's just the error about the summary.

pmepablo triaged this task as Low priority.Nov 21 2014, 6:01 AM
chad added a comment.Nov 21 2014, 6:32 AM

I believe summary is a text field, or 65k bytes. Is your summary longer than that?

epriestley added a subscriber: epriestley.Nov 21 2014, 12:57 PM

summary is only 80 bytes long on MySQL older than 5.5, but we truncate it to 80 characters, not 80 bytes.

The call to PhutilUTF8StringTruncator in PhabricatorRepositoryCommitData->summarizeCommitMessage() should use setMaximumBytes(), not setMaximumCodepoints().

We should review other uses of PhutilUTF8StringTruncator in case they have similar issues. Prior to T1191, columns were always measured in characters.

epriestley renamed this task from Phabricator daemons in error to Some use of PhutilUTF8StringTruncator are not aggressive enough.Dec 8 2014, 12:01 PM
epriestley added a project: Support Impact.

Support Impact This breaks things and users have no recourse other than reporting it.

beeerd mentioned this in T6742: Daemon tasks not processing, repository reports "Fully Imported".Dec 16 2014, 11:14 PM
beeerd added a subscriber: beeerd.Dec 18 2014, 1:09 AM
btrahan claimed this task.Dec 25 2014, 12:15 AM
btrahan added a revision: D11219: Fix string truncation calls all over the codebase..Jan 5 2015, 6:24 PM
btrahan added a revision: D11220: Remove "like MySQL" doc block hint.Jan 5 2015, 6:27 PM
btrahan closed this task as Resolved.Jan 5 2015, 7:14 PM
btrahan added a commit: rPHUb19a507367b5: Remove "like MySQL" doc block hint.
btrahan added a commit: rP384b670709aa: Fix string truncation calls all over the codebase..

Closed by commit rP384b670709aa.

pmepablo added a comment.Jan 6 2015, 11:03 PM

Thanks very much. I'll update this evening.

Phabricator · Built by Phacility