Page MenuHomePhabricator
Create Task
Maniphest T6606

Make /status/ route ignore host headers
Closed, WontfixPublic
Actions

Description

We could clean up a little bit of code if /status/ always gets to skip precursor checks like the Host header. This is generally helpful for anyone putting Phabricator behind a load balancer with HTTP health checks.

Event Timeline

epriestley created this task.Nov 20 2014, 11:26 PM
epriestley raised the priority of this task from to Wishlist.
epriestley updated the task description. (Show Details)
epriestley added a project: Phacility.
epriestley moved this task from Backlog to Do After Launch on the Phacility board.
epriestley added a subscriber: epriestley.
epriestley added a comment.Dec 4 2014, 7:01 PM

I made the admin role depend on the services library, so this got a little less bad already.

epriestley closed this task as Wontfix.Jan 5 2015, 5:30 PM
epriestley claimed this task.

The Phacility version if this is reasonably clean now, there are reasonable workarounds, and we haven't seen demand from installs.

joshuaspence added a subscriber: joshuaspence.Jun 29 2015, 6:07 AM

I'm actually facing a similar issue at the moment... what are the "reasonable workarounds"?

epriestley added a comment.Jun 29 2015, 1:19 PM

I worked around this in our SiteConfig subclass. You could conceivably also do it in preamble.php.

epriestley added a comment.Jun 29 2015, 1:20 PM

Or maybe even in Apache/nginx.

joshuaspence added a comment.Jun 29 2015, 1:21 PM

Yeah I have a hacky workaround that I can do in nginx, but it feels like it would be nicer to just allow /status/ to ignore the host header altogether.

Phabricator · Built by Phacility