Page MenuHomePhabricator

MySQL syntax highlight doesn't work for Pastes
Closed, ResolvedPublic

Description

I've created a paste and placed following SQL in it:

SELECT rc.id, CONCAT('http://phabricator.domain.com/r', r.callsign, rc.commitIdentifier) AS CommitUrl, COUNT(*) AS CommentCount, GROUP_CONCAT(tc.authorPHID SEPARATOR ', ')
FROM phabricator_audit.`audit_transaction_comment` tc
JOIN phabricator_repository.repository_commit rc ON rc.phid = tc.commitPHID
JOIN phabricator_repository.repository r ON r.id = rc.repositoryID
WHERE tc.`transactionPHID` IS NULL
GROUP BY rc.commitIdentifier

and then selected MySQL as it's language. The content of the paste wasn't highlighted at all when I've viewed it later.

P.S.
Pastes with PHP are properly highlighted.

Event Timeline

aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added a project: Paste.
aik099 added a subscriber: aik099.
aik099 renamed this task from Wrong syntax highlight for Pastes to MySQL syntax highlight doesn't work for Pastes.Nov 12 2014, 11:09 AM
aik099 updated the task description. (Show Details)

I can't immediately repro this -- P1416 seems to highlight fine:

Screen_Shot_2014-11-12_at_4.38.17_AM.png (1×1 px, 215 KB)

Can you reproduce the issue on this install?

Do you have Pygments installed? We use Pygments to highlight most languages, and have a builtin highlighter for PHP.

http://qa.in-portal.org/P1 - doesn't highlight.

Do you have Pygments installed? We use Pygments to highlight most languages, and have a builtin highlighter for PHP.

That's an interesting question. Let me check.

Pygments is installed (I've did yum install python-pygments.noarch and got answer back that package is installed)?

Maybe there are some manual steps that I need to complete to let Phabricator know where to find Pygments?

What a shame, I had pygments.enabled option set to false, which is default value. You can close this ticket now.

epriestley claimed this task.

@aik099 - consider making a donation - https://secure.phabricator.com/I2 - you are currently the leading user in terms of consuming our bandwidth day to day by a wide margin.

@aik099 - consider making a donation - https://secure.phabricator.com/I2

I see no problem with that. Maybe I can arrange so my company would make a donation as well. What donation means are supported, PayPal, direct bank transfer, anything else?

you are currently the leading user in terms of consuming our bandwidth day to day by a wide margin.

You mean, that I'm user, who is using Manifest most, are you certain? I see a lot of activity in Manifest so I'm sure I'm not the only user using it.

We currently have built out infrastructure for US / Canada credit or debit cards.

In terms of how you're leading Maniphest usage... For example, of the five most recent tasks in the system you filed 40% of them. One task about letting admins log in as other users is philosophically something this project isn't about, so other than educating you directly its a pure loss. This is the other task, and I guess there's small value here given we filed T6533.

Both of these tasks have multiple back and forths. In general you seem to like to debate things where we don't want the project headed that way, further consuming our time beyond the initial task creation.

Taking a step back, of the 62 tasks you've filed 15 have been resolved as "wontfix", 3 have been resolved as "invalid", and 15 more have been closed as "duplicate". Long story short, over half of the tasks you filed are thus firmly in the "the only value is educating aik099" category. Unfortunately, generating future work items is actually not valuable for our project since we are mostly resource-constrained and have a direction already in mind that will take us months if not years to get through.

You should probably hang out in IRC more and ask the community - that is not epriestley, chad, or myself but someone else hanging out there - about some of these questions / ideas you have. Its also probably worth looking through all the open tasks before you file something.

One task about letting admins log in as other users is philosophically something this project isn't about, so other than educating you directly its a pure loss.

One thing Manifest is missing is suggestion of other similar tasks from existing ones and search over documentation. I personally thought that not letting Admin users doing something is an error, but it turned out to be philosophy, that was explained on dedicated page, which wasn't liked anywhere on task posting page.

Maybe you should put a link to contribution documentation top of task reporting form, so everybody can read that upfront and know what stuff should be reported and what should not. One thing I remember from contributor docs is that bugs on prototype applications are not accepted.

Both of these tasks have multiple back and forths. In general you seem to like to debate things where we don't want the project headed that way, further consuming our time beyond the initial task creation.

That was my mistake in past, but after some time (and tickets submitted) my vision was inline with Phabricator team vision, which is we will reject most stuff, because supporting it in long term is costly because we're are a small team. So now if for submitted feature request I get No as answer then I go straight to my fork and implement it for my company purposes only (of course any code changes I made are on GitHub and publicly accessible for anybody to use). But I do love to debate, because in heat of debate the problem solution might come out.

Taking a step back, of the 62 tasks you've filed 15 have been resolved as "wontfix", 3 have been resolved as "invalid", ...

My approach here is to file a task in Manifest with feature/bug if I'm not getting any responses via IRC (people are not always in IRC, but they read e-mails coming from Manifest). In IRC you can miss the message and it gets lost. When ticket is filled-in Manifest, then people gets notified and even somebody outside of Phabricator team can answer whenever they will be online.

and 15 more have been closed as "duplicate"

Sorry for duplicates but how could I know that it is a duplicate of something, which might be phrased differently in original task.

Unfortunately, generating future work items is actually not valuable for our project since we are mostly resource-constrained and have a direction already in mind that will take us months if not years to get through.

I'm already aware of that. But I believe, that not sharing my feature ideas with community (via Manifest ticket creation) would be a loss. Chances are that somebody else might be wanting same feature or considering same thing as bug. This way I can know for sure.

Aside from donating, you should probably hang out in IRC more and ask the community - that is not epriestley, chad, or myself but someone else hanging out there - about some of these questions / ideas you have.

I ask epriestley on IRC as well for not to flood Manifest. There is a timezone issue with IRC, because majority of users seems to be from US and here at Riga there is night when most people come online.

Its also probably worth looking through all the open tasks before you file something.

That thing Manifest can automate, like YouTrack did: you start typing task title/text and ajax searches are made to locate similar tasks. This is much easier than doing manual search queries in different ways before reporting a task. I see a lot of duplicates on JetBrains YouTrack instance, that's human factor I guess: people do create duplicate tasks.

firmly in the "the only value is educating aik099" category.

That's not bad. Next time somebody searches the Manifest they can see the ideas for solving problems they're having. There is documentation on how to extend Phabricator, but it's not very detailed for newcomer to start extending Phabricator without asking any questions anywhere on how things work internally.

We currently have built out infrastructure for US / Canada credit or debit cards.

I would love to donate, but I don't have US credit/debit card. Please enable accepting credit cards issued in other countries (e.g. Europe) as well or maybe connect PayPal donation form. Then it would be possible for me to donate.

After asking you to donate given how you consume our bandwidth, and then explaining to you in detail how these contributions are largely a waste of time and just consuming our bandwidth, you chose to debate even more.

You are thus in danger of having your account disabled. Your "love of debate" needs to be tabled here, particularly when I am giving you instructions on how to best interact with us.

I do not need to lose an hour+ from my work day every day in this manner and nor do my coworkers.

Also, you have a made an assumption that the IRC channel isn't read - in fact, we log it on this instance and read it to completion - but as you now know since over 50% of what you ask for in Maniphest is a waste of our time a fair amount of what happens in IRC is also a waste of our time so we don't bother responding to it. Generally, we like it as a first order filter for folks like yourself - you can consider being ignored good signal that you are talking about something unimportant and / or esoteric.

Thank you for explaining. I will consider not answering in IRC as No answer by default now.

I'm not sure who is best reviewer for SVN-related patches, so please be so kind and look at D10840.