In quickstart.sql file the name column of differential_diffproperty table is varchar(255), but in DifferentialDiffProperty it's set to text128. This results in schema warning immediately after clear Phabricator installation.
I think that all non-Better Collation Available (because these might add utf8mb4 instead of utf8_general_ci, which might not be available for everybody) warning fixes should backported to the quickstart.sql as well.
This should already have been fixed by D10797. Here's name creating with varchar(128) and parameterized collation at HEAD:
Are you using an old quickstart?
It appears to be the case. I don't do git pull each day and the fix was commited yesterday :) You can safely close this then.
I've also noticed different schema issues with Almaniac, but wasn't sure if they are in resolving process already, so I haven't reported them.
It's expected that storage adjust will continue doing work forever, and occasionally apply changes even against clean schemata. For example, it's easiest for us to change keys now by just changing the definition and letting storage adjust make the actual change, rather than writing a separate patch, in most cases.
Can storage adjust also create new/delete existing columns? For me it changed types of columns and changed collations, but nothing more.
Also for cases, when a new column is added to a table and needs to be populated from old column that will be deleted, then using storage adjust can't help, because it will drop old column before migration script will be able to populate it.