Page MenuHomePhabricator

Update the quickstart.sql
ClosedPublic

Authored by epriestley on Nov 6 2014, 9:01 PM.
Tags
None
Referenced Files
F14052013: D10797.diff
Fri, Nov 15, 5:50 AM
F14037980: D10797.diff
Sun, Nov 10, 8:37 PM
F14024742: D10797.diff
Thu, Nov 7, 11:54 AM
F14002088: D10797.diff
Fri, Oct 25, 2:59 PM
F14002067: D10797.id25916.diff
Fri, Oct 25, 2:45 PM
F13997069: D10797.id.diff
Thu, Oct 24, 1:56 AM
F13995882: D10797.id25950.diff
Wed, Oct 23, 4:23 PM
F13977796: D10797.diff
Oct 18 2024, 8:07 PM
Subscribers

Details

Summary

Ref T1191. Use storage quickstart to regenerate quickstart.sql using modern schema construction statements.

This puts new installs into utf8mb4 mode immediately without requiring storage adjustment.

Test Plan
  • Ran arc unit --everything, which uses quickstart.
  • Ran bin/storage upgrade --namespace temp, to quickstart a new namespace.
  • Ran bin/storage upgrade --namespace temp --disable-utf8mb4, to quickstart a new namespace without utf8mb4 support.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Update the quickstart.sql.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
resources/sql/autopatches/20141106.dropold.sql
2

This is a very old table which was removed from quickstart long ago but may still exist on installs which have upgraded from day 1 using patches. It is unused.

(This wasn't shown by bin/storage adjust before because we didn't complain about errors.)

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementQuickstartWorkflow.php
142–146

Quality of life.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Nov 6 2014, 9:13 PM
This revision was automatically updated to reflect the committed changes.