Fixes T6336. Turns out that the function to update the import status updates that database and doesn't update the object. If the object doesn't get the pertinent update AND there's a herald rule that runs, then the object is later re-saved without ever getting the update flag.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T6336: Revision stuck in importing (after phabricator upgrade)
- Commits
- Restricted Diffusion Commit
rPba2963ecb3bb: Diffusion - fix commits not importing fully
logic in the ole sandbox and going to push it to prod and run re-parse on impacted commits
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/audit/editor/PhabricatorAuditEditor.php | ||
|---|---|---|
| 309–313 | I could also just make this one save? | |
Comment Actions
writeImportStatusFlag() is slightly safer than just doing a save() because it's race-resistant (it does an atomic write instead of a read-update-write). But maybe writeImportStatusFlag() could set the flag on the Commit.
Comment Actions
- update object import status as part of writing flag
- checked existing callsites and this is safe
- bonus bug fix - if a herald editor, then default the "Added by $name" to have $name as 'herald'.