Phabot macro detector does not tokenize works
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	cburroughs
	Aug 12 2014, 6:56 PM

Description

If someone says:

<cburroughs>  Foo bar allthethings foo bar

Phabaot should print spiffy ascii art, but

<cburroughs> FooallthethingsBar  !allthethings! :allthethings: Supercalifragilisticexpialiallthethingsdocious

should not.

Current behavior:

<Bob> :frogsiren: :dizzy_face: :frogsiren:
<phabot>                                   !::,.           
<phabot>                                  .,,,::,   .*,..  
<phabot>                                ..,*,;,,,,:,.,:,,. 
<phabot>                              ,||!::::,,,,,,,,::,! 
<phabot>                           .,,,|$###@@@@*;,,,,,,,; 
<phabot>                   .:;;;||@====#$$###$$#$$$*!,,,,; 
<phabot>                   ,.  .*$@$##!|$$$##$##$$###@|:,! 
<phabot>             .::::@$$###$|$$$##!,:::;========!::;! 
<phabot>          .,,,,,,,,|==@=:,;!;;:..........,,,,,:::: 
<phabot>         ,,..,=$@###*|$$$#$,                       
<phabot>       .,,,,,,,*===*:,;!;,                         
<phabot>      ,,...*$@$##*!$$$#$,                          
<phabot>    .:;;;|||$###@||=@@|                            
<phabot>    ,!;;!=$@$###*#$$#@.                            
<phabot>   *@==$#$@$##$#$$$##.                             
<phabot>  ;*!;;!@$###@!=$$#$;                              
<phabot>  |||;;;;!|!!;;;;;;!;:                             
<phabot>  |||!!;;;;;;;;!@@!;;;;                            
<phabot>  |||!;!;;;;;;;;|!;;;!!.                           
<phabot>  !!;;;;;!!!!!!!;;!!!;;.                           
<phabot>  ;!;;;;;;;;;;;;;;;;;!,                            
<phabot>  ;!!!!!;;;;;;;;;!;;;;;,                           
<Bob> wasnt me

Revisions and Commits

rP Phabricator
	D10242	rP5183bf3c4981 Detect macros more strictly in bot handler

Event Timeline

cburroughs created this task.Aug 12 2014, 6:56 PM

cburroughs raised the priority of this task from to Needs Triage.

cburroughs updated the task description. (Show Details)

cburroughs added a project: Phabot.

cburroughs added a subscriber: cburroughs.

I think we should require the entire line be a macro, for consistency with the web UI rules.

That is, only:

username> frogsiren

...would trigger it, not:

username> frogsiren is cool

Even better.

epriestley added a revision: D10242: Detect macros more strictly in bot handler.Aug 12 2014, 8:58 PM

Closed by commit rP5183bf3c4981.

Phabot macro detector does not tokenize worksClosed, ResolvedPublicActions

Description

Revisions and Commits

Event Timeline

Phabot macro detector does not tokenize works
Closed, ResolvedPublic
Actions