Detect macros more strictly in bot handler
ClosedPublic
Actions

Authored by epriestley on Aug 12 2014, 8:58 PM.

Tags

None

Referenced Files

	F13236409: D10242.id24648.diff
	Tue, May 21, 9:37 AM

	F13210936: D10242.diff
	Fri, May 17, 5:20 AM

	F13194833: D10242.diff
	Sun, May 12, 9:55 PM

	F13182221: D10242.id.diff
	Thu, May 9, 9:15 PM

	F13182213: D10242.diff
	Thu, May 9, 9:07 PM

	F13179304: D10242.diff
	Wed, May 8, 9:06 PM

	Unknown Object (File)
	Sat, May 4, 7:15 PM

	Unknown Object (File)
	Sat, May 4, 12:42 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T5863: Phabot macro detector does not tokenize works

Commits

Restricted Diffusion Commit
rP5183bf3c4981: Detect macros more strictly in bot handler

Summary

Fixes T5863. Like Remarkup, only identify macros if the entire chat line is the macro.

Test Plan

https://secure.phabricator.com/chatlog/channel/6/?at=158229

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24645.Aug 12 2014, 8:58 PM

epriestley retitled this revision from to Detect macros more strictly in bot handler.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5863: Phabot macro detector does not tokenize works.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 12 2014, 8:58 PM

Harbormaster completed remote builds in B2181: Diff 24645.Aug 12 2014, 9:00 PM

btrahan accepted this revision.Aug 12 2014, 9:02 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 12 2014, 9:02 PM

Closed by commit rP5183bf3c4981 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

bot/

handler/

PhabricatorBotMacroHandler.php

4 lines

Diff 24648

View Options

src/infrastructure/daemon/bot/handler/PhabricatorBotMacroHandler.php

Detect macros more strictly in bot handlerClosedPublicActions