Detect macros more strictly in bot handler
ClosedPublic
Actions

Authored by epriestley on Aug 12 2014, 8:58 PM.

Tags

None

Referenced Files

	F18910724: D10242.diff
	Sun, Nov 9, 3:22 AM

	F18847998: D10242.diff
	Oct 30 2025, 3:00 AM

	F18842620: D10242.diff
	Oct 28 2025, 5:00 PM

	F18769576: D10242.id.diff
	Oct 8 2025, 8:09 AM

	F18765153: D10242.diff
	Oct 7 2025, 9:54 AM

	F18096126: D10242.id24645.diff
	Aug 8 2025, 4:35 AM

	F17967842: D10242.diff
	Aug 1 2025, 12:42 PM

	F17924505: D10242.id.diff
	Jul 30 2025, 10:03 AM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T5863: Phabot macro detector does not tokenize works

Commits

Restricted Diffusion Commit
rP5183bf3c4981: Detect macros more strictly in bot handler

Summary

Fixes T5863. Like Remarkup, only identify macros if the entire chat line is the macro.

Test Plan

https://secure.phabricator.com/chatlog/channel/6/?at=158229

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24645.Aug 12 2014, 8:58 PM

epriestley retitled this revision from to Detect macros more strictly in bot handler.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5863: Phabot macro detector does not tokenize works.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 12 2014, 8:58 PM

Harbormaster completed remote builds in B2181: Diff 24645.Aug 12 2014, 9:00 PM

btrahan accepted this revision.Aug 12 2014, 9:02 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 12 2014, 9:02 PM

Closed by commit rP5183bf3c4981 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

bot/

handler/

PhabricatorBotMacroHandler.php

4 lines

Diff 24648

View Options

src/infrastructure/daemon/bot/handler/PhabricatorBotMacroHandler.php

Detect macros more strictly in bot handlerClosedPublicActions