Page MenuHomePhabricator
Create Task
Maniphest T5798

Fix performance issues with Paste browse list
Closed, ResolvedPublic
Actions

Description

  • The /paste/ list is really slow if you use S3 for file storage since we have to make up to 100 synchronous calls to do cache fills.
    • We should just cache the first few lines of a paste on the object, and fill the cache on edit.
  • It also looks like the cache may not be behaving correctly since subsequent loads are also slow.
    • Figure out what's wrong with it.
  • Finally, S3 calls don't show up in DarkConsole services. All file engine requests should appear there.
    • Add service event calls so they get logged.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

epriestley created this task.Aug 5 2014, 4:52 PM
epriestley raised the priority of this task from to Low.
epriestley updated the task description. (Show Details)
epriestley added a project: Paste.
epriestley added a subscriber: epriestley.
epriestley added a subscriber: btrahan.Aug 6 2014, 6:29 PM

This is a reasonably impactful quality-of-life issue for Paste if you use S3, if you want to tackle it.

btrahan claimed this task.Aug 7 2014, 10:15 PM

Sounds fun. Note this is on the bottom of the recent set I picked up and I'll look at it last.

btrahan added a revision: Restricted Differential Revision.Aug 19 2014, 6:34 PM
btrahan closed this task as Resolved.Aug 19 2014, 6:57 PM
btrahan added a commit: Restricted Diffusion Commit.

Closed by commit rPed98a1cc8464.

Phabricator · Built by Phacility