Differential D10294

Paste - fix caching mechanism for S3-stored files
ClosedPublic
Actions

Authored by btrahan on Aug 19 2014, 6:34 PM.

Tags

None

Referenced Files

	F13149411: D10294.id.diff
	Sat, May 4, 8:56 AM

	Unknown Object (File)
	Fri, May 3, 2:33 AM

	Unknown Object (File)
	Tue, Apr 30, 10:52 AM

	Unknown Object (File)
	Mon, Apr 29, 2:06 PM

	Unknown Object (File)
	Thu, Apr 25, 11:38 PM

	Unknown Object (File)
	Thu, Apr 25, 11:37 PM

	Unknown Object (File)
	Wed, Apr 24, 10:10 PM

	Unknown Object (File)
	Sun, Apr 21, 4:32 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T5798: Fix performance issues with Paste browse list

Commits

Restricted Diffusion Commit
rPed98a1cc8464: Paste - fix caching mechanism for S3-stored files

Summary

Fixes T5798. We basically weren't using the caching mechanism. Also adds service calls for S3 stuff, and support for seeing a little info like you can for conduit.

Test Plan

uploaded a paste, looked at paste list - no s3 service calls. edited the paste, looked at paste list - no s3 service calls and edited content properly shown

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24789.Aug 19 2014, 6:34 PM

btrahan added a task: T5798: Fix performance issues with Paste browse list.

btrahan retitled this revision from to Paste - fix caching mechanism for S3-stored files.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 19 2014, 6:34 PM

Harbormaster completed remote builds in B2271: Diff 24789.Aug 19 2014, 6:35 PM

epriestley accepted this revision.Aug 19 2014, 6:57 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 19 2014, 6:57 PM

Closed by commit rPed98a1cc8464 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

aphront/

console/

plugin/

DarkConsoleServicesPlugin.php

1 line

applications/

files/

engine/

PhabricatorS3FileStorageEngine.php

27 lines

paste/

query/

PhabricatorPasteSearchEngine.php

4 lines

Diff 24791

src/aphront/console/plugin/DarkConsoleServicesPlugin.php

Loading...

src/applications/files/engine/PhabricatorS3FileStorageEngine.php

Loading...

src/applications/paste/query/PhabricatorPasteSearchEngine.php

Loading...