Page MenuHomePhabricator

Make it easier to partially quote comments
Closed, WontfixPublic

Description

If quoting only a part of a comment, right now one has to manually remove all of the non-relevant quoted content. It would be useful to be able to select only a part of a comment, and then hit quote, which only inserts the selected portion as quote in the comment editor

Event Timeline

timor raised the priority of this task from to Needs Triage.
timor updated the task description. (Show Details)
timor added projects: Maniphest, Differential, Audit.
timor added a subscriber: timor.
epriestley claimed this task.

We have no mapping of selected display characters to remarkup. For example, I'm going to use two hard-to-quote blocks:

______ < hi > ------ \ ^__^ \ (oo)\_______ (__)\ )\/\ ||----w | || ||
a
b
c

If you select halfway into the cow, or halfway into the code block, and we just quote all the text characters up to that point, the quoted text will be dramatically different from the original text when rendered (e.g., missing closing formatting elements, and there's no way to generate half a cow).

In T5496#4, @epriestley wrote:

If you select halfway into the cow, or halfway into the code block, and we just quote all the text characters up to that point, the quoted text will be dramatically different from the original text when rendered (e.g., missing closing formatting elements, and there's no way to generate half a cow).

Is there no mapping at all, or is it just hard to make unique? One solution to that specific example would be to not quote the blocks if they are not selected in their entirety.

The current behavior is as good as email and your usual web forum, meeting default users' expectations. Rendering HTML based on arbitrary selections of text is an obscure science with many options to fail or misbehave.