Page MenuHomePhabricator

bin/phd broken by rP0ccebbe4b1d
Closed, ResolvedPublic

Description

After upgrading Phabricator to the latest master, I get the following error when running any bin/phd command, like stop, start, status.

vagrant@vagrant-ubuntu-trusty-64:/opt/code/phabricator$ bin/phd  stop
[2014-06-16 23:51:53] EXCEPTION: (InvalidArgumentException) Argument 1 passed to PhabricatorDaemonReference::newFromDictionary() must be of the type array, string given, called in /opt/code/phabricator/src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php on line 50 and defined at [<phutil>/src/error/PhutilErrorHandler.php:201]
  #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/infrastructure/daemon/control/PhabricatorDaemonReference.php:26]
  #1 PhabricatorDaemonReference::newFromDictionary(string) called at [<phabricator>/src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php:50]
  #2 PhabricatorDaemonManagementWorkflow::loadRunningDaemons() called at [<phabricator>/src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php:282]
  #3 PhabricatorDaemonManagementWorkflow::executeStopCommand(array) called at [<phabricator>/src/applications/daemon/management/PhabricatorDaemonManagementStopWorkflow.php:24]
  #4 PhabricatorDaemonManagementStopWorkflow::execute(PhutilArgumentParser) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:396]
  #5 PhutilArgumentParser::parseWorkflowsFull(array) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:292]
  #6 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/daemon/manage_daemons.php:23]

If I checkout to the commit right before rP0ccebbe4b1d (specifically rP78635a15c108) then the error goes away.

Event Timeline

bluehawk raised the priority of this task from to Needs Triage.
bluehawk updated the task description. (Show Details)
bluehawk added a subscriber: bluehawk.
zorfling added a project: Daemons.
zorfling added a subscriber: zorfling.

Yep, me too.

I'm just going to back this out since loadRunningDaemons() is super messed up right now. Sorry, should have caught this stuff in review...

This was just a land gone awry, we'll get these changes back in properly soon. HEAD should be in good shape for now.

All good, back to working now :)
Thanks.