Bug reproduction:
- Drag something to phabricator home without releasing the mouse button just yet
- Chicken out and press the escape key
- Phabricator hates you and locks the interface
Only way out is reloading the page.
Bug reproduction:
Only way out is reloading the page.
rP Phabricator | |||
D10102 | rP6a66d19a2d0f Global upload - fix for Firefox |
I am not immediately able to reproduce this, at least in Chrome, can you give a more specific set of steps to reproduce (including OS/Browser)? Does it repro on secure.phabricator.com?
Drag a file from somewhere (desktop or whatever) to the Phabricator dashboard. Phabricator should show you a message about uploading files. Before releasing your mouse button, press ESC to lock the interface.
including OS/Browser
Windows Server 2012, Firefox 29.0.1
Does it repro on secure.phabricator.com?
Yes, it does.
This is what I am doing to attempt reproduce, please correct me if I am wrong:
On Windows Server 2012 / Firefox 29:
Is that correct?
I have tested Firefox 29.0.1 on Mac, Win7, and Win8. I don't have Server 2012.
The comment area works fine, should have clarified that. It only seems to affect the dashboard/home.
Looks like a bug in Firefox:
https://bugzilla.mozilla.org/show_bug.cgi?id=656164
This:
http://stackoverflow.com/a/12928838/821226
Claims this:
https://gist.github.com/meleyal/3794126
...is a workaround, although I don't quite understand exactly what's going on there immediately.
A simple alternative fix would be to let you click the overlay to dismiss it.
Messed with this for awhile...
I added some debugging code to omit the depth whenever it is updated. What is strange is that in Firefox, the depth is typically 2 while you drag all around the home page, while the depth is typically 1 in other browsers. Firefox DOES seem to decrement correctly when I drag outside the window; its already off by one though so this doesn't work right.
I am not sure what Firefox is doing under the hood to achieve this oddness.
Attached diff is the simple fix.