Page MenuHomePhabricator

Homepage file drag & drop locks up on Firefox when pressing ESC
Closed, ResolvedPublic

Description

Bug reproduction:

  1. Drag something to phabricator home without releasing the mouse button just yet
  2. Chicken out and press the escape key
  3. Phabricator hates you and locks the interface

Only way out is reloading the page.

Revisions and Commits

Event Timeline

GMTA raised the priority of this task from to Needs Triage.
GMTA updated the task description. (Show Details)
GMTA added a subscriber: GMTA.

I am not immediately able to reproduce this, at least in Chrome, can you give a more specific set of steps to reproduce (including OS/Browser)? Does it repro on secure.phabricator.com?

In T5188#3, @chad wrote:

can you give a more specific set of steps to reproduce

Drag a file from somewhere (desktop or whatever) to the Phabricator dashboard. Phabricator should show you a message about uploading files. Before releasing your mouse button, press ESC to lock the interface.

including OS/Browser

Windows Server 2012, Firefox 29.0.1

Does it repro on secure.phabricator.com?

Yes, it does.

This is what I am doing to attempt reproduce, please correct me if I am wrong:

On Windows Server 2012 / Firefox 29:

  • Go to any comment field on Phabricator, for example new task.
  • Drag a .jpg file from the Desktop into the comment area.
  • Hit ESC
  • Browser locks up

Is that correct?

I have tested Firefox 29.0.1 on Mac, Win7, and Win8. I don't have Server 2012.

In T5188#6, @chad wrote:

This is what I am doing to attempt reproduce, please correct me if I am wrong:

  • Go to any comment field on Phabricator, for example new task.
  • Drag a .jpg file from the Desktop into the comment area.

The comment area works fine, should have clarified that. It only seems to affect the dashboard/home.

chad renamed this task from Interface locks up when ESC pressed during drag & drop to Homepage file drag & drop locks up on Firefox when pressing ECS.May 26 2014, 5:16 PM
chad updated the task description. (Show Details)

Awesome, that repro's easily for me

You can also just pick up a file, wave it over the screen, and then put it back.

chad renamed this task from Homepage file drag & drop locks up on Firefox when pressing ECS to Homepage file drag & drop locks up on Firefox when pressing ESC.May 26 2014, 6:06 PM
chad triaged this task as Low priority.

Looks like a bug in Firefox:

https://bugzilla.mozilla.org/show_bug.cgi?id=656164

This:

http://stackoverflow.com/a/12928838/821226

Claims this:

https://gist.github.com/meleyal/3794126

...is a workaround, although I don't quite understand exactly what's going on there immediately.

A simple alternative fix would be to let you click the overlay to dismiss it.

Messed with this for awhile...

I added some debugging code to omit the depth whenever it is updated. What is strange is that in Firefox, the depth is typically 2 while you drag all around the home page, while the depth is typically 1 in other browsers. Firefox DOES seem to decrement correctly when I drag outside the window; its already off by one though so this doesn't work right.

I am not sure what Firefox is doing under the hood to achieve this oddness.

Attached diff is the simple fix.