Page MenuHomePhabricator

Fix git "origin" remote in more circumstances
ClosedPublic

Authored by epriestley on Nov 20 2013, 4:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 16, 6:46 PM
Unknown Object (File)
Sun, Feb 9, 10:37 AM
Unknown Object (File)
Sun, Feb 9, 10:37 AM
Unknown Object (File)
Sun, Feb 9, 10:37 AM
Unknown Object (File)
Sun, Feb 9, 10:37 AM
Unknown Object (File)
Sat, Feb 8, 1:40 AM
Unknown Object (File)
Thu, Jan 30, 7:42 PM
Unknown Object (File)
Tue, Jan 28, 6:01 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T4041: updates on bare repos fail when git < 1.7.2
Commits
Restricted Diffusion Commit
rPa07f444f2a5e: Fix git "origin" remote in more circumstances
Summary

Fixes T4041. We currently detect when "origin" is incorrect, but can do better:

  • When "origin" is missing, we can add it. This happens for Git 1.7.1 -- see T4041.
  • When "origin" is wrong, we can fix it automatically if we control the repository.

We only need to fail when origin exists, is wrong, and we aren't in charge of the repository.

Test Plan

Ran bin/repository discover X on a repository with a good origin, no origin, a bad-but-under-control origin, and a bad-out-of-control origin. Got the right behavior in all cases.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped