Page MenuHomePhabricator
Create Task
Maniphest T4879

Maniphest email notification text is cropped
Closed, InvalidPublic
Actions

Description

@epriestley, I think that I found small bug while we discussed about another bug :D
You wrote this: https://secure.phabricator.com/T4878#5

I got email notification:

epriestley added a project: Easy
epriestley added a comment.

This can be fixed like this:

  - in `PhabricatorApplicationTransactionEditor`, implement `buildMailBody()`

TASK DETAIL
  https://secure.phabricator.com/T4878

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.

To: epriestley
Cc: rugabarbo

But your comment was longer than I got.
Is it bug?

Event Timeline

rugabarbo created this task.Apr 23 2014, 3:34 PM
rugabarbo assigned this task to epriestley.
rugabarbo raised the priority of this task from to Needs Triage.
rugabarbo updated the task description. (Show Details)
rugabarbo added a project: Maniphest.
rugabarbo added a subscriber: rugabarbo.
epriestley closed this task as Resolved.Apr 23 2014, 3:42 PM

Haha, this was just my mistake. I hit submit too quickly, by somehow managing to type like five keys wrong in a row. I then edited my message to correct the mistake. You can see that the message was edited in the upper right ("Edited") and click that link for an edit history.

rugabarbo changed the task status from Resolved to Invalid.Apr 23 2014, 3:50 PM

Haha :D
Thanks for explanations.

It's about me:

double-facepalm

epriestley added a subscriber: chad.Apr 23 2014, 4:16 PM

One possible issue is that the "edited" text is pretty easy to miss. An easy fix would maybe be to make it more colorful.

@chad, do you have any thoughts this?

Personally, I'd probably prefer a slightly more visible indicator, but the default was this more subtle indicator and most of the other UIs I use a lot (Reddit, Facebook) have subtle links, so I took the lazy route and didn't swap it for something garish at the time.

chad added a comment.Apr 23 2014, 4:42 PM

Slightly prefer how it is now, which is 'available if you look for it'. The other design approach would be something under the copy, like a footer - such that you read the copy then you read that it was edited.

epriestley added a comment.Apr 23 2014, 4:43 PM

Sounds reasonable. Let's leave it for now and we can play with it if more users hit issues.

This is sort of an unusual case anyway since edits are normally minor, rather than "I forgot to type most of the text".

Phabricator · Built by Phacility