Page MenuHomePhabricator
Create Task
Maniphest T4878

Paste notification doesn't contain link to it
Closed, ResolvedPublic
Actions

Description

Steps:

  1. Go to some paste (for example: P11)
  2. Click "Subscribe"
  3. Wait while somebody add a comment to it
  4. Open email notification:

    <nickname> added a comment. <details>

    REPLY HANDLER ACTIONS Reply to comment or !unsubscribe.

    To: <nickname> Cc: <nickname1>, <nickname2>, ..., <nicknameN>
  1. This notification doesn't contain link to paste

Revisions and Commits

rP Phabricator
D8861rP5e80901cecf0 Email paste link

Event Timeline

rugabarbo created this task.Apr 23 2014, 2:48 PM
rugabarbo assigned this task to epriestley.
rugabarbo raised the priority of this task from to Needs Triage.
rugabarbo updated the task description. (Show Details)
rugabarbo added a project: Paste.
rugabarbo added a subscriber: rugabarbo.
epriestley added a project: Badge Awarded.EditedApr 23 2014, 2:52 PM

This can be fixed like this:

  • in PhabricatorApplicationTransactionEditor, implement buildMailBody()
  • have it add a PASTE DETAIL section
  • see DifferentialTransactionEditor::buildMailBody() for an example.
rugabarbo claimed this task.Apr 23 2014, 3:23 PM
rugabarbo triaged this task as Low priority.
rugabarbo edited this Maniphest Task.Apr 25 2014, 6:40 PM
rugabarbo edited this Maniphest Task.Apr 25 2014, 6:50 PM
rugabarbo closed this task as Resolved.Apr 25 2014, 6:50 PM

Closed by commit rP5e80901cecf0.

Phabricator · Built by Phacility