Page MenuHomePhabricator
Create Task
Maniphest T4819

"Duplicate" status should not appear in Maniphest Edit UI unless a task is already closed as a duplicate
Closed, ResolvedPublic
Actions

Description

If you "Edit Task", the "Status" dropdown includes the custom status marked with the special "duplicate" role. It should not, unless the task is currently in that status. Users should normally be able to move to that status only by performing a task merge.

This doesn't need to be validated on the server side since it's fine if a user messes with the form to push things into "duplicate" status directly, this is just a usability/confusion issue.

Original Description/

In Phabricator you can click "Edit Task" and set the Status to DUPLICATE without the requirement to mention what task it was duped on/merged into. It seems that you need to specify the task duplicated as a comment in a separate action, but would expect the option to provide the number of the other task directly.

Revisions and Commits

rP Phabricator
D8902rP1d5731b1ae3c Restrict marking task duplicate to "merge duplicates" workflow

Event Timeline

aklapper created this task.Apr 17 2014, 12:56 PM
aklapper raised the priority of this task from to Needs Triage.
aklapper updated the task description. (Show Details)
aklapper added a project: Maniphest.
aklapper added a subscriber: aklapper.
epriestley added a subscriber: epriestley.Apr 17 2014, 1:03 PM

This is probably a bug; that status should not appear in "Edit Task" unless the task already has the status. I'll fix this.

Use the "Merge Duplicates In" action to merge duplicates. This will handle closing the duplicate, bringing users over, and annotating both tasks.

merge.png (195×316 px, 15 KB)

epriestley renamed this task from Mark as duplicate and define the duplicated task at once to "Duplicate" status should not appear in Maniphest Edit UI unless a task is already closed as a duplicate.Apr 17 2014, 1:09 PM
epriestley triaged this task as Normal priority.
epriestley updated the task description. (Show Details)
epriestley added a project: Badge Awarded.
epriestley assigned this task to lpriestley.Apr 17 2014, 10:53 PM
  • The code to render this control is in ManiphestTaskEditController.
  • You can determine which status is the "duplicate" status by calling ManiphestTaskStatus::getDuplicateStatus() (installs can reconfigure the statuses, so the actual value may vary from install to install).
qgil added a subscriber: qgil.Apr 22 2014, 5:42 AM
lpriestley edited this Maniphest Task.Apr 29 2014, 6:29 PM
lpriestley edited this Maniphest Task.Apr 29 2014, 6:41 PM
lpriestley closed this task as Resolved.Apr 29 2014, 6:41 PM

Closed by commit rP1d5731b1ae3c.

Phabricator · Built by Phacility