Page MenuHomePhabricator

Support for 72-character line length
Closed, DuplicatePublic

Description

It would be great if diffusion (and other Phabricator applications) had support from a 72-character line length which is recommended for git. Currently, 72-character commit messages will appear in diffusion wrapped at 72 characters, whereas it would be better to not perform this wrapping within the web interface (as the 72-character limit is intended for the CLI).

Event Timeline

joshuaspence raised the priority of this task from to Wishlist.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Diffusion.
joshuaspence added a subscriber: joshuaspence.

To clarify, you want us to unwrap the text when showing it in the web UI? I think that's not possible in the general case, as wrapping destroys information (we can not distinguish between newlines caused by wrapping and formatting newlines).

Yes, that is essentially what I am asking for.

I think that this request is possible, although they may be corner cases which are difficult to handle. I believe that GitHub currently do something similar with Markdown (unwrapping the width of the text) although I'm not familiar with the details. There is also a similar request for GitLab to do the same (citation needed).

Can you show me an example on GitHub? Here's the first commit I looked at, which clearly hasn't been unwrapped:

https://github.com/git/git/commit/fe191fcaa58cb785c804465a0da9bcba9fd9e822

โœ˜ Merged into T5028.

This isn't quite the same as T5028... What I am asking for here is that all remarkup (whether it be commit messages or READMEs or whatever else) be

Currently, in HEAD, I think they all are. That is, commit messages already discarded linebreaks, and READMEs do too now. Or are you not seeing that?

From T5028, it looks like you're not seeing that.

โœ˜ Merged into T5028.