Page MenuHomePhabricator

Previous revisions not being auto-closed
Closed, DuplicatePublic

Description

It seems that previous differentials which had been accepted and landed (but not closed) were not auto-closed after reimporting the repository. The differential correctly links to a commit in the parent repository, but it seems that this alone was not enough to trigger the differential to be auto-closed.

Is this the expected behaviour? I feel as if the differential should be auto-closed in this scenario. Is there an easy way to reprocess a given repository and auto-close landed differentials?

Event Timeline

joshuaspence renamed this task from Previous Revisions Not Being Auto-Closed to Previous revisions not being auto-closed.
joshuaspence assigned this task to epriestley.
joshuaspence raised the priority of this task from to Normal.
joshuaspence updated the task description. (Show Details)
joshuaspence added a subscriber: joshuaspence.

During initial import, we disable a lot of side effects of import, including autoclose. The intent is to prevent, e.g., importing a copy of a repository to test something from closing thousands of old tasks/revisions, sending thousands of Herald notifications, publishing thousands of feed stories, etc.

My guess is that's the issue here. If you explicitly want this side effect, you should be able to run (now that the repository is imported):

phabricator/ $ ./scripts/repository/reparse.php --message --all X

...where X is the repository callsign. Note that this will also close tasks (e.g., Fixes T123 in messages), but will not trigger feed publishing, Owners, or Herald rules.

No, this doesn't seem to work. Although I'm talking about autoclosing diffs, not maniphests.

Okay, I'm not immediately sure what's up, then.

Let me try adding more diagnostic information to the UI and/or daemon output.