Page MenuHomePhabricator

Incorrect "only adding or removing whitespace" shield being applied to origin of moved and modified files.
Closed, ResolvedPublic

Description

Repro Steps:

  1. Move an existing file to a new path.
  2. Make small non-whitespace modifications to that file
  3. Arc Diff

Result: "This file was changed only by adding or removing whitespace" shield is applied to the origin of the moved file, immediately after yellow bar stating: "This file was moved to ..." It seems in this case no shield should be applied - as the contents of the new file differ from the old contents and the old file has been deleted.

Event Timeline

cdentel raised the priority of this task from to Low.
cdentel updated the task description. (Show Details)
cdentel added a project: Phabricator.
cdentel added a subscriber: cdentel.

I was able to repro by following the steps. Probably not going to look at this super soon, but the next time I'm in that code I'll see what's going on.

This was also reported in T6107.

Howsabout if there just isn't a shield in these cases?

Yeah, these files shouldn't shield.