Page MenuHomePhabricator

Hide tooltips on any keypress
ClosedPublic

Authored by epriestley on Mar 12 2014, 1:30 PM.
Tags
None
Referenced Files
F15486601: D8497.diff
Thu, Apr 10, 8:18 AM
F15472126: D8497.id20174.diff
Sat, Apr 5, 11:02 AM
F15462400: D8497.diff
Tue, Apr 1, 2:53 PM
F15449801: D8497.id20174.diff
Fri, Mar 28, 12:20 PM
F15403033: D8497.id20174.diff
Tue, Mar 18, 1:42 AM
F15392712: D8497.diff
Sat, Mar 15, 5:11 PM
F15380153: D8497.id20174.diff
Fri, Mar 14, 1:41 AM
F15344261: D8497.id20174.diff
Mar 10 2025, 3:34 AM

Details

Summary

Fixes T4586, where a keystroke like "return" to submit a form could remove DOM nodes rendering a tooltip, leaving the user with a permanent phantom tooltip.

(@spicyj, if you come up with anything better than this feel free to send a followup, but I think this is a reasonable fix.)

A nice side effect of this is that it hides any tooltips obscuring a text input when you start typing.

Test Plan

Hovered over a tooltip, pressed a key, tip vanished.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Hide tooltips on any keypress.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, sophiebits.
epriestley added a subscriber: sophiebits.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2014, 4:19 PM
epriestley updated this revision to Diff 20174.

Closed by commit rP82aeb59ecf9e (authored by @epriestley).