Our company has many different git branches other than master. Every time someone uploads a diff, we don't know what git HASH it is actually diffing against. It would be extremely helpful if arc uploads the current git hash info alongside the Branch+Arcanist Project information (and the hash be a link).
Description
Description
Revisions and Commits
Revisions and Commits
Event Timeline
Comment Actions
This should be shown in the "Base" column of the diff table, but we could do a better job about linking it.
Comment Actions
BTW how difficult is it to show which branch we landed on? That is also very helpful to have.
Comment Actions
What do you imagine the UI looking like? A revision can be associated with arbitrarily many commits, and each commit can be on arbitrarily many branches, so there's no simple "Landed To: master" answer.
Comment Actions
So a very common problem that is happening in my company is that people do a "arc diff origin/<name-of-remote-branch>" and then the reviewer is confused as to whether the review is done against origin/master or origin/live or origin/<something-else>. The current UI only shows the branch name of the local branch.
A very helpful information to have for our particular workflow (which is, only diffing against one branch at a time), is to show what the person is diff'ing against (e.g. "Diff Against: origin/live-v029").
Comment Actions
Low priority, but a couple of quick feature improvements here that will make Differential nicer and move us closer to mobile:
- Use more modern UI elements in the "Local Commits" table, like D8504 did for the "Revision Update History" table.
- In both tables, use DiffusionCommitQuery to try to look up all the commit hashes before we render the tables and see if they correspond to commits we know about already. For hashes we know about, link them to Diffusion.