Differential D8679

Differential - modernize "Local Commits" table
ClosedPublic
Actions

Authored by btrahan on Apr 2 2014, 7:58 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T4585: Base git hash should be displayed on Differential.

Commits

Restricted Diffusion Commit
rPc6cbff199712: Differential - modernize "Local Commits" table

Summary

...also link to commits we know about in "Local Commits" and "Revision Update History" tables. Fixes T4585.

Test Plan

made a repo. made a diff (foo) and committed it (bar). made a new diff that was comprised of two local commits. noted links to (bar) in various commit hashes as expected

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 20583.Apr 2 2014, 7:58 PM

btrahan added a task: T4585: Base git hash should be displayed on Differential..

btrahan retitled this revision from to Differential - modernize "Local Commits" table.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: chad, Korvin, epriestley.Apr 2 2014, 7:58 PM

Screen_Shot_2014-04-02_at_12.58.47_PM.png (1×1 px, 436 KB)

dude.

I am working on (Table of Contents) modernizing. I almost started this next lolz.

Whoops! Glad we just avoided some duplication of effort. :) I just took a quick grok of my task list and I think this is the only "modernize" type one. I have a few quasi-UI tasks in there but they all require some backendy component (so more like how this adds links and not just a modernize pass).

epriestley accepted this revision.Apr 2 2014, 8:08 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/differential/view/DifferentialLocalCommitsView.php
42–44	It looks like this highlight stuff isn't used and can be nuked? I think the alt/$rowc stuff is automatic, too. Do things still work if you simply remove it?
105–108	I'd expect maybe more/fewer columns here for $has_tree / $has_local? If there is a bug here, it should show up as weird formatting for SVN/hg/copy-pasted diffs.
122–127	Now unused?