| joshuaspence | |
| Mar 9 2014, 8:38 PM |
| F124988: Screen_Shot_2014-03-09_at_1.58.06_PM.png | |
| Mar 9 2014, 8:59 PM |
| F124985: Screen_Shot_2014-03-09_at_1.55.49_PM.png | |
| Mar 9 2014, 8:59 PM |
The CSS for Differential seems broken for mobile. Some fonts seem to be
much smaller than others. I have attached a screenshot.
My user agent is `*Mozilla/5.0 (Linux; Android 4.4.2; Nexus 5 Build/KOT49H)
AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.136 Mobile
Safari/537.36*`.
Joshua Spence
This is "known", in the sense that the page isn't marked device-ready. Do other device-ready pages (like Maniphest task detail pages) look OK?
When we mark a page device-ready, it adds viewport tags which make diffs 100% unusable (since you can't zoom into them) instead of just 90% unusable like they are now.
Making Differential device-ready is covered in T2004 (and maybe T2009 and a few linked tasks). Broadly, we need a 1-up view for diffs, since devices generally can not accommodate a side-by-side view sensibly. This kind-of exists but isn't accessible in the UI and hasn't gotten any work in a while.
I think your user-agent in particular is exceptionally broken on that page -- here's the same page on the iPhone simulator:
On a marked-for-devices page like the Maniphest detail page, we should be emitting the tags to get a usable render:
Does that line up with your experiences on your device? If so, I think we should probably just merge this into T2004. We could try to implement some kind of stopgap so that your agent isn't as broken, but T2004 is obviously cleaner/better.
I'm merging this into the Differential Task, though I think it's not necessary to implement a basic mobile version, since we overflow the 2-up diff area already. There are some other areas that need fixed though as well.