Page MenuHomePhabricator

Temporary files do not inherit permissions from their parents
Closed, ResolvedPublic

Description

Problem: Temporary files created by Diffusion a la "View Raw File" link are exempt from any permissions imposed on their originating repository.

Expected: Viewing a file should not expose it to all users of the system until manually deleted.

Proposal: At the time of creation, temporary files should retain a reference to the permission rules set on their parent repository where applicable, so that Phabricator may beckon thee away as it would if the user were trying to browse the repository that they are unauthorized to view.

Kudos: Kudos may be sprinkled on every other facet of Phabricator from front-end to rear. This is one marvelous project.

Event Timeline

bezeek raised the priority of this task from to Needs Triage.
bezeek updated the task description. (Show Details)
bezeek added a project: Files.
bezeek added a subscriber: bezeek.
epriestley triaged this task as Normal priority.

Ah, thanks. The policy system supports this already, it just needs to be hooked up.

The patch is working just swimmingly so far. Thanks!