Page MenuHomePhabricator

Bind patches, file content and raw diffs bind policies to their originating objects
ClosedPublic

Authored by epriestley on Dec 28 2013, 12:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 6:15 PM
Unknown Object (File)
Fri, Apr 12, 6:14 AM
Unknown Object (File)
Sat, Apr 6, 7:13 AM
Unknown Object (File)
Sat, Mar 30, 11:59 PM
Unknown Object (File)
Feb 23 2024, 10:39 AM
Unknown Object (File)
Jan 26 2024, 6:55 AM
Unknown Object (File)
Jan 19 2024, 5:45 PM
Unknown Object (File)
Jan 19 2024, 5:45 PM
Subscribers

Details

Summary

Fixes T4270. When you download raw file content, diffs, and patches we currently give them default (all users) visibility.

Instead, bind them to the repository or revision in question.

(This code could use a bit of cleanup at some point.)

Test Plan

Hit the patch and content download links in Diffusion and the patch download link in Differential, got restricted files with accurate policy bindings.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped