Page MenuHomePhabricator

Bind patches, file content and raw diffs bind policies to their originating objects
ClosedPublic

Authored by epriestley on Dec 28 2013, 12:26 AM.
Tags
None
Referenced Files
F15504707: D7849.id17763.diff
Mon, Apr 14, 7:53 PM
F15484521: D7849.id17758.diff
Wed, Apr 9, 6:46 PM
F15484214: D7849.id.diff
Wed, Apr 9, 5:10 PM
F15479671: D7849.diff
Tue, Apr 8, 8:39 AM
F15478191: D7849.id17763.diff
Mon, Apr 7, 8:57 PM
F15478190: D7849.id17758.diff
Mon, Apr 7, 8:57 PM
F15478189: D7849.id.diff
Mon, Apr 7, 8:57 PM
F15469797: D7849.id17763.diff
Fri, Apr 4, 4:35 PM
Subscribers

Details

Summary

Fixes T4270. When you download raw file content, diffs, and patches we currently give them default (all users) visibility.

Instead, bind them to the repository or revision in question.

(This code could use a bit of cleanup at some point.)

Test Plan

Hit the patch and content download links in Diffusion and the patch download link in Differential, got restricted files with accurate policy bindings.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped