Page MenuHomePhabricator

Related events should be grouped in timeline views
Closed, ResolvedPublic

Description

When creating/manipulating tasks/revisions/whatever, there are often several events that are done as part of a single step. For example, consider the following event log from creating a task and subsequently claiming the task/commenting on it:

{F93428}

In this screenshot, there are 5 separate events reported:

  1. Creating the task
  2. Adding myself as a subscriber
  3. Changing the view permissions
  4. Claiming the task
  5. Issuing a comment.

What's not clear from this view, however, is that there were actually only two transactions:

  1. Created the cask (1, 2, 3)
  2. Claiming (and commenting on) the task (4, 5)

I think it would be nice if operations that are part of a single transaction are grouped together. First, I think it will make the timeline view quite a bit cleaner, and second more clearly associate comments with the action to which they are related.

Event Timeline

wotte raised the priority of this task from to Needs Triage.
wotte updated the task description. (Show Details)
wotte added a project: Phabricator.
wotte added a subscriber: wotte.

Yeah, we had this before and it was pretty sweet but it hasn't made it to ApplicationTransactions yet. See D7107 for context and partial support. This is supported by the UI element (see https://secure.phabricator.com/uiexample/view/PhabricatorTimelineExample/) but it looks pretty terrible. There are also some JS issues with the anchor highlighting.

I see what you mean. I think something that would go a long way to fixing the way that last one looks is to align all text that doesn't have an icon with everything that does; text jumping between two different alignments is pretty jarring.

Yeah. I think this is entirely tractable, my first effort didn't quite get there.

epriestley claimed this task.

Okay -- this happens now, and seems not terrible based on looking at it for 3 seconds. I'm going to leave T4266 open for any followup/tweaking/feedback, since that has a more substantive discussion anyway and @chad mentioned he wanted to touch up the UI a bit.