Page MenuHomePhabricator

Warn when a user runs a Herald rule against an importing, non-publishing or disabled repository
Closed, ResolvedPublic

Description

See IRC. We currently don't make it clear to users that Herald rules won't fire against Importing/Inactive/Non-publishing repositories. The Herald Test Console should print a hard-to-miss warning message on the transcript.

Event Timeline

epriestley renamed this task from Warn a user runs a Herald rule against an importing, non-publishing or disabled repository to Warn when a user runs a Herald rule against an importing, non-publishing or disabled repository.
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Herald.
epriestley added a subscriber: epriestley.

A related issue is that repository interfaces generally don't show "still importing" status, but this affects a lot of things, like the action of "Close T123" and interacting with Differential.

When a repository is importing, we should probably show a global banner in all of Diffusion to the effect of "this is still importing".

  • When viewing the transcript of a commit in an importing, disabled, or "herald-disabled"/publish-disabled repository, display a prominent warning on the page that Herald rules won't trigger against this repository, e.g. "The rX repository is still importing. Herald rules won't start triggering until import completes.").
  • When viewing pretty much any page in a repository that's still importing, display a prominent warning that the repo is still importing and not everything will work yet.