Page MenuHomePhabricator
Create Task
Maniphest T3948

Headers inside property lists lost their divider line
Closed, DuplicatePublic
Actions

Description

I think there used to be a horizontal rule on these, but it looks like it's gone. Was that intentional? I think it made them a lot easier to pick out.

{F68346}

Event Timeline

epriestley created this task.Oct 13 2013, 1:04 AM
epriestley assigned this task to chad.
epriestley raised the priority of this task from to Low.
epriestley updated the task description. (Show Details)
epriestley added a subscriber: epriestley.

Specifically, "FRIENDSHIP" and "AUTOBIOGRAPHY".

chad added a subscriber: chad.Oct 13 2013, 2:05 AM

Yes they were all removed. Grouping property lists provides the rule now. Alternatively we could provide an addRule function?

epriestley claimed this task.Oct 13 2013, 2:15 AM

Ah, okay. I'll figure something out when I do the tab JS.

chad added a comment.Oct 13 2013, 2:22 AM

Yeah it just seemed better to make 'sections' actively created instead of being passive to a sectionheader. Then if you wanted header, text, text, header, text, it can exist in one section. But how to fix for customfields... unclear.

epriestley closed this task as a duplicate.Oct 22 2013, 4:01 PM

✘ Merged into T4014.

Phabricator · Built by Phacility