Page MenuHomePhabricator

By default, do not save queries when executing Conduit "*.search" calls
ClosedPublic

Authored by epriestley on Jul 9 2016, 1:50 PM.
Tags
None
Referenced Files
F15186773: D16263.id39132.diff
Fri, Feb 21, 3:55 AM
F15185913: D16263.id39132.diff
Thu, Feb 20, 11:44 PM
Unknown Object (File)
Sun, Feb 16, 7:05 AM
Unknown Object (File)
Sun, Feb 9, 1:59 AM
Unknown Object (File)
Sun, Feb 9, 1:59 AM
Unknown Object (File)
Sun, Feb 9, 1:59 AM
Unknown Object (File)
Sun, Feb 9, 1:59 AM
Unknown Object (File)
Thu, Jan 30, 9:20 AM
Subscribers
None

Details

Summary

Fixes T11304. Prior to this change, we did an unnecessary write on every "*.search" call (this write didn't always actually write a row, since we only save unique saved queries, but still doesn't do anything useful ever, currently).

Instead, change this to not-write by default. We could add an "oh, and also I want you to do a write" option later, which would let us implement something like arc query-stuff which says "To see more results, view this URI in your browser: ...".

(It's possible to run one of these methods with an existing SavedQuery by using the key, so we still sometimes have a queryKey to return.)

Test Plan

Ran almanac.service.search, used DarkConsole to verify that no serachengine writes occurred.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to By default, do not save queries when executing Conduit "*.search" calls.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2016, 5:24 PM
This revision was automatically updated to reflect the committed changes.