Page MenuHomePhabricator
Create Task
Maniphest T10835

The "Tags" is used instead of "Projects" word in curtain of differential revision/commit page
Closed, ResolvedPublic
Actions

Description

How to Reproduce:

  1. create a Project
  2. add Differential Revision to a Project
  3. add Diffusion Commit to a Project

Both Differential Revision and Commit can be associated with a project using their edit page. After recent UI change however the text above associated project list says "Tags" instead of projects. This becomes even more confusing on commit detail page, where on left side commit tags (from VCS) are shown but on right side projects names are shown, but has tags label.

Phabricator_Revision_WrongTagsLabel.png (673×1 px, 157 KB)

Phabricator_Commit_WrongTagsLabel.png (575×1 px, 110 KB)

I merge stable branch into my own Phabricator fork to have controlled upgrade process and this ends up in showing my merge commit as version. Latest merge was done when https://secure.phabricator.com/w/changelog/2016.15/ was latest change log entry.

Revisions and Commits

rP Phabricator
ClosedD15753 Consistently refer to 'Projects' as 'Tags'

Related Objects

Event Timeline

aik099 created this task.Apr 19 2016, 7:52 AM
eadler claimed this task.Apr 19 2016, 3:22 PM
eadler added a revision: D15753: Consistently refer to 'Projects' as 'Tags'.

The upstream is moving to a direction where "Tags" are being used in situations where a project is being associated with a thing. This is because (I think) because people assumed objects could only be associated with a single project.

aik099 added a comment.Apr 19 2016, 4:09 PM

The upstream is moving to a direction where "Tags" are being used in situations where a project is being associated with a thing. This is because (I think) because people assumed objects could only be associated with a single project.

That's understandable. In some places projects act as tags (e.g. on the commit page) and I was wondering why it's called Projects and not Tags.

Still some renaming needs to be done to solve double tag problem with Differential Revision and Diffusion Commit pages.

eadler mentioned this in rPc9daa2b0ad1e: Consistently refer to 'Projects' as 'Tags'.Apr 19 2016, 4:48 PM
eadler closed this task as Resolved.Apr 19 2016, 4:54 PM
eadler added a subscriber: chad.

I'm going to close this since the upstream is going in a different direction. There may be some confusion around diffusion and differential, but I think @chad wanted to use the term "project tags" for that.

aik099 added a comment.Apr 19 2016, 6:35 PM

OK.

Phabricator · Built by Phacility