Page MenuHomePhabricator

Reviews can return to "blocking others" even after approval
Closed, DuplicatePublic

Description

Repo:

  1. Create a project (we'll call it OWNERS), include a user (call them USER).
  2. In Herald, create a rule that adds OWNERS as a blocking reviewer for incoming changes.
  3. Create a new change. Herald should add OWNERS automatically as a blocking reviewer.
  4. Have USER approve the change. Note that USER's "Blocking others" list will not include the change.
  5. Update the change.
  6. Note that USER's "Blocking changes" now includes the change again, despite their approval never changing.

Related Objects