Daemons are crashing with error (InvalidArgumentException) Argument 1 passed to PhabricatorApplicationTransaction::shouldHideForMail() must be of the type array, none given
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	clemvangelis
	Feb 9 2016, 10:35 AM

Description

Since last phabricator update, daemons are crashing on the following error.

Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100] [2016-02-09 11:32:19] EXCEPTION: (PhutilProxyException) Error while executing Task ID 9151156. {>} (InvalidArgumentException) Argument 1 passed to PhabricatorApplicationTransaction::shouldHideForMail() must be of the type array, none given, called in /home/phabricator/phabricator/src/applications/maniphest/storage/ManiphestTransaction.php on line 185 and defined at [<phutil>/src/error/PhutilErrorHandler.php:200]
Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100] arcanist(head=master, ref.master=57f6fb59d739), phabricator(head=master, ref.master=0782652a8059), phutil(head=master, ref.master=f43291e99d36)
Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100]   #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/transactions/storage/PhabricatorApplicationTransaction.php:567]
Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100]   #1 <#2> PhabricatorApplicationTransaction::shouldHideForMail() called at [<phabricator>/src/applications/maniphest/storage/ManiphestTransaction.php:185]
Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100]   #2 <#2> ManiphestTransaction::shouldHideForMail(array) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2417]
Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100]   #3 <#2> PhabricatorApplicationTransactionEditor::buildMailForTarget(ManiphestTask, array, PhabricatorMailTarget) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2385]
Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100]   #4 <#2> PhabricatorApplicationTransactionEditor::buildMail(ManiphestTask, array) called at [<phabricator>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1099]
Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100]   #5 <#2> PhabricatorApplicationTransactionEditor::publishTransactions(ManiphestTask, array) called at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:21]
Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100]   #6 <#2> PhabricatorApplicationTransactionPublishWorker::doWork() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorWorker.php:122]
Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100]   #7 <#2> PhabricatorWorker::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php:171]
Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100]   #8 <#2> PhabricatorWorkerActiveTask::executeTask() called at [<phabricator>/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php:22]
Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100]   #9 PhabricatorTaskmasterDaemon::run() called at [<phutil>/src/daemon/PhutilDaemon.php:183]
Daemon 15068 STDE [Tue, 09 Feb 2016 11:32:20 +0100]   #10 PhutilDaemon::execute() called at [<phutil>/scripts/daemon/exec/exec_daemon.php:125]

Can not give reproduction instruction for the moment since it happens from last pull but this is surely due to @epriestley commit f84130f9cd7463178fc27a0cfad1f8be5f5ddb43 which introduce shouldHideEmail method.