find-unaccepted-revisions.php
ActivePublic
Actions

Authored by epriestley on Dec 1 2015, 10:54 PM.

Tags

None

Referenced Files

	F1010190: find-unaccepted-revisions.php
	Dec 1 2015, 10:54 PM

Subscribers

chad

	<?php

	require_once 'scripts/__init_script__.php';

	$viewer = PhabricatorUser::getOmnipotentUser();

	$table = new DifferentialRevision();
	foreach (new LiskMigrationIterator($table) as $rev) {
	if ($rev->getStatus() != ArcanistDifferentialRevisionStatus::CLOSED) {
	continue;
	}

	$rev = id(new DifferentialRevisionQuery())
	->setViewer($viewer)
	->withIDs(array($rev->getID()))
	->needReviewerStatus(true)
	->executeOne();
	if (!$rev) {
	continue;
	}

	$reviewers = $rev->getReviewerStatus();
	$any_accept = false;
	foreach ($reviewers as $reviewer) {
	$status = $reviewer->getStatus();
	if (($status == DifferentialReviewerStatus::STATUS_ACCEPTED) \|\|
	($status == DifferentialReviewerStatus::STATUS_ACCEPTED_OLDER)) {
	$any_accept = true;
	break;
	}
	}

	if ($any_accept) {
	continue;
	}

	$id = $rev->getID();

	echo "D{$id} is closed without any accepting reviewers.\n";
	}

	echo "Done.\n";

Event Timeline

epriestley changed the title of this paste from untitled to find-unaccepted-revisions.php.Dec 1 2015, 10:54 PM

epriestley edited the content of this paste. (Show Details)

We need a Pay $5 to see this extension button.

ᵐᶦᶜʳᵒᵖᵃʸᵐᵉᶰᵗˢ﹗

My major concern with pursuing that (or, say, "$1 to file a task") is that user expectations will be like billion times higher if something costs $0.25 than if it's free.

I'd love to find a way to align stuff around small financial incentives since I think it really could cut down on a lot of the fluff, but I think it could cause a lot of badness too.

Maybe once we get Nuance online we can explore a "$5 priority queue" or something.

what about a jimmy wales banner ad?

(i don't want to charge users for stuff, I just wanted to say ᵐᶦᶜʳᵒᵖᵃʸᵐᵉᶰᵗˢ)

We also probably need to implement Phabricator Credits before we can add ᵐᶦᶜʳᵒᵖᵃʸᵐᵉᶰᵗˢ because otherwise we'll just be paying Stripe for the privilege of having ᵐᶦᶜʳᵒᵖᵃʸᵐᵉᶰᵗˢ.

find-unaccepted-revisions.phpActivePublicActions

Event Timeline

find-unaccepted-revisions.php
ActivePublic
Actions