Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F88072
D7709.diff
All Users
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
808 B
Referenced Files
None
Subscribers
None
D7709.diff
View Options
diff --git a/src/applications/doorkeeper/engine/DoorkeeperImportEngine.php b/src/applications/doorkeeper/engine/DoorkeeperImportEngine.php
--- a/src/applications/doorkeeper/engine/DoorkeeperImportEngine.php
+++ b/src/applications/doorkeeper/engine/DoorkeeperImportEngine.php
@@ -53,6 +53,12 @@
$xobj = $ref
->newExternalObject()
->setImporterPHID($viewer->getPHID());
+
+ // NOTE: Fill the new external object into the object map, so we'll
+ // reference the same external object if more than one ref is the
+ // same. This prevents issues later where we double-populate
+ // external objects when handed duplicate refs.
+ $xobjs[$ref->getObjectKey()] = $xobj;
}
$ref->attachExternalObject($xobj);
}
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/52/w4/7ge6d43d2ucighpj
Default Alt Text
D7709.diff (808 B)
Attached To
Mode
D7709: Fix an edge case when trying to pull duplicate refs via Doorkeeper
Attached
Detach File
Event Timeline
Log In to Comment