Page MenuHomePhabricator

Fix an edge case when trying to pull duplicate refs via Doorkeeper
ClosedPublic

Authored by epriestley on Dec 5 2013, 3:36 AM.
Tags
None
Referenced Files
F15583838: D7709.id17428.diff
Thu, May 8, 12:07 AM
F15575936: D7709.id17412.diff
Tue, May 6, 7:39 AM
F15575934: D7709.id17428.diff
Tue, May 6, 7:39 AM
F15572672: D7709.diff
Mon, May 5, 5:07 PM
F15561714: D7709.diff
Tue, Apr 29, 10:01 PM
F15546477: D7709.id17428.diff
Sat, Apr 26, 3:50 PM
F15536796: D7709.diff
Thu, Apr 24, 10:55 AM
F15523906: D7709.diff
Mon, Apr 21, 4:35 AM
Subscribers

Details

Summary

Report from Asana. In some unclear circumstances, we my attempt to resolve duplicate refs which currently ends up hitting a duplicate key error.

Instead, reference the same external object if we happen to be handed duplicate refs.

Test Plan

Used this script to reproduce the issue. Applied the fix; issue went away:

#!/usr/bin/env php
<?php

require_once 'scripts/__init_script__.php';

$args = new PhutilArgumentParser($argv);
$args->parseStandardArguments();

$ref = id(new DoorkeeperObjectRef())
  ->setApplicationType(DoorkeeperBridgeAsana::APPTYPE_ASANA)
  ->setApplicationDomain(DoorkeeperBridgeAsana::APPDOMAIN_ASANA)
  ->setObjectType(DoorkeeperBridgeAsana::OBJTYPE_TASK)
  ->setObjectID(7253737283629); // Use a new task ID which we've never pulled.

$refs = array(clone $ref, clone $ref);

$asana_user = id(new PhabricatorPeopleQuery())
  ->setViewer(PhabricatorUser::getOmnipotentUser())
  ->withUsernames(array('asana'))
  ->executeOne();

$resolved_refs = id(new DoorkeeperImportEngine())
  ->setViewer($asana_user)
  ->setRefs($refs)
  ->execute();

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped