Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F86249
D7631.id17223.diff
All Users
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
877 B
Referenced Files
None
Subscribers
None
D7631.id17223.diff
View Options
diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php
--- a/src/applications/repository/storage/PhabricatorRepository.php
+++ b/src/applications/repository/storage/PhabricatorRepository.php
@@ -580,14 +580,9 @@
// Make sure we don't leak anything if this repo is using HTTP Basic Auth
// with the credentials in the URI or something zany like that.
- if ($uri instanceof PhutilGitURI) {
- if (!$this->getDetail('show-user', false)) {
- $uri->setUser(null);
- }
- } else {
- if (!$this->getDetail('show-user', false)) {
- $uri->setUser(null);
- }
+ // If repository is not accessed over SSH we remove both username and password
+ if (!($uri instanceof PhutilGitURI)) {
+ $uri->setUser(null);
$uri->setPass(null);
}
File Metadata
Details
Attached
Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/ct/gq/ys3vhgiyirvn6m6t
Default Alt Text
D7631.id17223.diff (877 B)
Attached To
Mode
D7631: Set reasonable defaults when displaying remote repository URIs.
Attached
Detach File
Event Timeline
Log In to Comment