Paths

Table of Contentst

Set reasonable defaults when displaying remote repository URIs.
ClosedPublic
Actions

Authored by frgtn on Nov 22 2013, 6:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 4, 6:38 PM

	Unknown Object (File)
	Tue, Apr 30, 11:21 PM

	Unknown Object (File)
	Mon, Apr 29, 7:34 PM

	Unknown Object (File)
	Mon, Apr 29, 7:34 PM

	Unknown Object (File)
	Mon, Apr 29, 7:34 PM

	Unknown Object (File)
	Mon, Apr 29, 7:34 PM

	Unknown Object (File)
	Mon, Apr 29, 7:33 PM

	Unknown Object (File)
	Sat, Apr 27, 4:43 PM

Subscribers

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4147: Restore some form of clone URI customization for Diffusion remotes

Commits

Restricted Diffusion Commit
rP4910a36563a6: Set reasonable defaults when displaying remote repository URIs.

Summary

Show SSH user on git-over-ssh repositories and hide both username and password for other repos.

Test Plan

View repository details page in diffusion, Clone URI should appear with a username (taken from repo config) and any http(s) repos should be without usernames.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Update libphutil to clear that lint.

src/applications/repository/storage/PhabricatorRepository.php
584	I think `$this->shouldUseSSH()` is a better check. We want to show username data for explicit SSH Git, too, e.g.: ssh://git@github.com/blah/blah

Remove lint.

Use shouldUseSSH to check for ssh uris.

Closed by commit rP4910a36563a6 (authored by @frgtn, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

12 lines

Diff 17226

View Options

src/applications/repository/storage/PhabricatorRepository.php

Set reasonable defaults when displaying remote repository URIs.ClosedPublicActions