Show SSH user on git-over-ssh repositories and hide both username and password for other repos.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4147: Restore some form of clone URI customization for Diffusion remotes
- Commits
- Restricted Diffusion Commit
rP4910a36563a6: Set reasonable defaults when displaying remote repository URIs.
View repository details page in diffusion, Clone URI should appear with a username (taken from repo config) and any http(s) repos should be without usernames.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Update libphutil to clear that lint.
| src/applications/repository/storage/PhabricatorRepository.php | ||
|---|---|---|
| 584 | I think $this->shouldUseSSH() is a better check. We want to show username data for explicit SSH Git, too, e.g.: ssh://git@github.com/blah/blah | |