Page MenuHomePhabricator

Set reasonable defaults when displaying remote repository URIs.
ClosedPublic

Authored by frgtn on Nov 22 2013, 6:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 1:09 AM
Unknown Object (File)
Thu, Nov 28, 5:26 PM
Unknown Object (File)
Tue, Nov 26, 10:00 AM
Unknown Object (File)
Tue, Nov 26, 10:00 AM
Unknown Object (File)
Tue, Nov 26, 10:00 AM
Unknown Object (File)
Tue, Nov 26, 10:00 AM
Unknown Object (File)
Tue, Nov 26, 10:00 AM
Unknown Object (File)
Tue, Nov 26, 9:37 AM

Details

Summary

Show SSH user on git-over-ssh repositories and hide both username and password for other repos.

Test Plan

View repository details page in diffusion, Clone URI should appear with a username (taken from repo config) and any http(s) repos should be without usernames.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Update libphutil to clear that lint.

src/applications/repository/storage/PhabricatorRepository.php
584

I think $this->shouldUseSSH() is a better check. We want to show username data for explicit SSH Git, too, e.g.:

ssh://git@github.com/blah/blah
frgtn updated this revision to Unknown Object (????).Nov 22 2013, 6:58 PM
  • Remove lint.
frgtn updated this revision to Unknown Object (????).Nov 22 2013, 7:21 PM
  • Use shouldUseSSH to check for ssh uris.
epriestley closed this revision.

Closed by commit rP4910a36563a6 (authored by @frgtn, committed by @epriestley).