Page MenuHomePhabricator

D7508.diff

diff --git a/src/applications/diffusion/controller/DiffusionController.php b/src/applications/diffusion/controller/DiffusionController.php
--- a/src/applications/diffusion/controller/DiffusionController.php
+++ b/src/applications/diffusion/controller/DiffusionController.php
@@ -8,6 +8,8 @@
$request = $this->getRequest();
$uri = $request->getRequestURI();
+ $user_agent = idx($_SERVER, 'HTTP_USER_AGENT');
+
// Check if this is a VCS request, e.g. from "git clone", "hg clone", or
// "svn checkout". If it is, we jump off into repository serving code to
// process the request.
@@ -27,6 +29,8 @@
//
// ...to get a human-readable error.
$vcs = $request->getExists('__vcs__');
+ } else if (strncmp($user_agent, "git/", 4) === 0) {
+ $vcs = PhabricatorRepositoryType::REPOSITORY_TYPE_GIT;
} else if ($request->getExists('service')) {
$service = $request->getStr('service');
// We get this initially for `info/refs`.
@@ -541,6 +545,16 @@
return null;
}
+ if (!strlen($username)) {
+ // No username.
+ return null;
+ }
+
+ if (!strlen($password->openEnvelope())) {
+ // No password.
+ return null;
+ }
+
$user = id(new PhabricatorPeopleQuery())
->setViewer(PhabricatorUser::getOmnipotentUser())
->withUsernames(array($username))

File Metadata

Mime Type
text/x-diff
Storage Engine
amazon-s3
Storage Format
Raw Data
Storage Handle
phabricator/4s/fz/wjsz4tdkel43zw5a
Default Alt Text
D7508.diff (1 KB)

Event Timeline