Don't throw when user tries to use an empty password via HTTP auth
ClosedPublic
Actions

Authored by epriestley on Nov 5 2013, 11:15 PM.

Tags

None

Referenced Files

	F18830341: D7508.id16930.diff
	Sat, Oct 25, 6:20 AM

	F18786648: D7508.id16929.diff
	Tue, Oct 14, 7:49 PM

	F18737441: D7508.diff
	Wed, Oct 1, 10:42 AM

	F18640633: D7508.diff
	Sep 18 2025, 5:51 PM

	F18594112: D7508.id.diff
	Sep 12 2025, 5:02 PM

	F18584217: D7508.diff
	Sep 11 2025, 12:20 PM

	F18583791: D7508.diff
	Sep 11 2025, 11:10 AM

	F18087758: D7508.id16929.diff
	Aug 6 2025, 5:20 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4064: Empty password not handled correctly for Git clone

Commits

Restricted Diffusion Commit
rPce48375951bd: Don't throw when user tries to use an empty password via HTTP auth

Summary

Fixes T4064. See discussion there.

Test Plan

Tried git clone http://... with empty password, got 403. Retried with actual password, got a clone.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 5 2013, 11:21 PM

Closed by commit rPce48375951bd (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionController.php

14 lines

Diff 16930

View Options

src/applications/diffusion/controller/DiffusionController.php

Don't throw when user tries to use an empty password via HTTP authClosedPublicActions