Don't throw when user tries to use an empty password via HTTP auth
ClosedPublic
Actions

Authored by epriestley on Nov 5 2013, 11:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 2:49 AM

	Unknown Object (File)
	Fri, Dec 13, 1:28 AM

	Unknown Object (File)
	Fri, Dec 6, 3:42 PM

	Unknown Object (File)
	Thu, Dec 5, 2:09 AM

	Unknown Object (File)
	Wed, Dec 4, 10:32 AM

	Unknown Object (File)
	Wed, Dec 4, 10:32 AM

	Unknown Object (File)
	Wed, Dec 4, 10:32 AM

	Unknown Object (File)
	Wed, Dec 4, 10:22 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Maniphest Tasks

T4064: Empty password not handled correctly for Git clone

Commits

Restricted Diffusion Commit
rPce48375951bd: Don't throw when user tries to use an empty password via HTTP auth

Summary

Fixes T4064. See discussion there.

Test Plan

Tried git clone http://... with empty password, got 403. Retried with actual password, got a clone.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Nov 5 2013, 11:21 PM

Closed by commit rPce48375951bd (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionController.php

14 lines

Diff 16930

View Options

src/applications/diffusion/controller/DiffusionController.php

Don't throw when user tries to use an empty password via HTTP authClosedPublicActions